From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 9A9454D7F9
	for <ffmpegdev@gitmailbox.com>; Sun, 20 Apr 2025 16:07:29 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 239A7687C8C;
	Sun, 20 Apr 2025 19:07:25 +0300 (EEST)
Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com
 [209.85.128.45])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B0D4C687C8C
 for <ffmpeg-devel@ffmpeg.org>; Sun, 20 Apr 2025 19:07:18 +0300 (EEST)
Received: by mail-wm1-f45.google.com with SMTP id
 5b1f17b1804b1-440685d6afcso30635535e9.0
 for <ffmpeg-devel@ffmpeg.org>; Sun, 20 Apr 2025 09:07:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745165237; x=1745770037; darn=ffmpeg.org;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :from:to:cc:subject:date:message-id:reply-to;
 bh=mdpJGdUiucAfyZVRGz8bnonFA7QauBSWxsRRhx3NpfI=;
 b=mJjhVMIddYNXxq/TjCZr0/Dp+0Gs67FCvBHysDNkAxFK/QbfMCzrbM/Imib51dh6e1
 4Txj6it1xkEhDxKaJFsu2D9gi3YQg3Ha+7DBukRnzsosNpVXJRwngKJJAs2BP42nnMbi
 pDPPSpzn5O+yMYbZFO9gIQtzLObKaBE1bkTRRvENhZ/rCZuZL7lzESEgHZvVfXRrlnHi
 /C7jpHPolTVS7IDLKpXYQlt1bYp2F3HKFwfaXk4YOMyZIIM6E5W++R6UUlcSuYI8zGx+
 6DU0BeH33cBavi2NLqef8vbJyJjrkTrAc2pEdHAsqssfhiBDtUYQ5gbJiPKvJD1nF5+F
 yfOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745165237; x=1745770037;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=mdpJGdUiucAfyZVRGz8bnonFA7QauBSWxsRRhx3NpfI=;
 b=AfHhwP3jOGsjsKLp2f+B3At/zXbQpIUPBXLBLRl0LkGyVHOKB7OBjpMjWDsfx7uPvH
 qX/gfKbxQeVKKm8nZlGmSz2OYuxg7cACiA3dggPzijiSnF49gHiMwZFLe0EYsyGovenY
 1/FJs3TjjeKcLs9epWitzAXVl+QH90rMKQBrAHbFsiR4W8uMmwb15Vl1/CtQQIyLKJLq
 QKwapGINLYGqENoI3LuwV+p9nNlt2kXQH1r3EdqW/Y/bBGYhYKWJww1nISBM9QDPVSX+
 FHAttOGAe1rUdrimoiIXOJAKs8pwBwPgTGDexHOiPZm1lbD00D5oMffrfqyRQrA/DbWJ
 CrNA==
X-Gm-Message-State: AOJu0YyvVsbxGCjcH+o8hfx7M9meOHK6qPs9i4J8z+/NuvqvEywmbzwb
 5unSXWxs7UddzRMbuRuHXngvUWrio51UhL7Ab5N5vPIE37SAwQI5WVa8ug==
X-Gm-Gg: ASbGnctmId1gnoi3WKVcpit7WtkWchSOyVWNnA+1hOZ4Qd7esx4lEIdX3XHv4EEpVTQ
 zbo+0zjfl7+TqCEW5JSgCgpizl1t6jGbOxWOW20U7nb2eay8MWOm1sb1/IS/O9E08szedwokLYP
 fAXQ4Z5D0vrZblsIlBBEi18S3aCq0Rz8GAh3+ZCB4M3sgqxPMsfDhpHVgSibjSgMkLoruSdmW7x
 u2bXc2Wjl4YkYlGmArDEe6mXKz3FRYzL9VJaTqmY5BBDHuNSpNc+viRfqc1UExjNs3s42f6cIM3
 xvcIsLkqKGbWEDGaBGhGApIV+uvfh2I7pDlEo4Imc8Pkh6eEM4TM4oQ4FHQk5bDwAYyRgjvP3qX
 0IUsJW7nHDyMz
X-Google-Smtp-Source: AGHT+IHNsBlkQyUwDo/qOZ7EvfdUzXOA1MjGq7braVK0cdAQX9vaXSMwAavPTQgRb57YRnpDPnqrwg==
X-Received: by 2002:a5d:6d81:0:b0:39c:1429:fa57 with SMTP id
 ffacd0b85a97d-39efba384ddmr6270551f8f.3.1745165236989; 
 Sun, 20 Apr 2025 09:07:16 -0700 (PDT)
Received: from [192.168.1.106] (33bf1e4c.skybroadband.com. [51.191.30.76])
 by smtp.googlemail.com with ESMTPSA id
 ffacd0b85a97d-39efa4a5150sm9100669f8f.82.2025.04.20.09.07.16
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 20 Apr 2025 09:07:16 -0700 (PDT)
Message-ID: <ab126a51-4d81-4234-9b86-d785a7c4d902@gmail.com>
Date: Sun, 20 Apr 2025 17:07:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: ffmpeg-devel@ffmpeg.org
References: <20250419190712.1265201-1-sw@jkqxz.net>
 <20250419190712.1265201-3-sw@jkqxz.net>
From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
In-Reply-To: <20250419190712.1265201-3-sw@jkqxz.net>
Subject: Re: [FFmpeg-devel] [PATCH 2/6] lavf: APV demuxer
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/ab126a51-4d81-4234-9b86-d785a7c4d902@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 4/19/2025 8:07 PM, Mark Thompson wrote:
> +typedef struct APVHeaderInfo {
> +    uint8_t  pbu_type;
> +    uint16_t group_id;
> +
> +    uint8_t  profile_idc;
> +    uint8_t  level_idc;
> +    uint8_t  band_idc;
> +
> +    uint32_t frame_width;
> +    uint32_t frame_height;
> +
> +    uint8_t  chroma_format_idc;
> +    uint8_t  bit_depth_minus8;
> +
> +    enum AVPixelFormat pixel_format;
> +} APVHeaderInfo;

Possibly this should put in the codec private data, and used
in the decoder directly, since APV in ISOBMFF requires a global
APVDecoderConfigurationRecord to be used - i.e. align with that.
Mostly because I imagine that is how most APV is produced on
phones.

(Also, just excited to see APV!)

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".