From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F200E44252 for ; Mon, 5 Dec 2022 06:11:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 37AC968BCE8; Mon, 5 Dec 2022 08:11:14 +0200 (EET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9896E68BC68 for ; Mon, 5 Dec 2022 08:11:12 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670220672; x=1701756672; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=Mv7e2qJ0//R30dlKMwiPNAhJ3qdA8PxTPKRgBXCFstk=; b=BdLUhPGhhdGiVHsYVcy30hLr/uHtigqaOwgZv2iZ8UKs27o0WJEhrBEH I1rVpQNcKvQM5SmAfqdr4y0XGbPLZhrWNlIIztJ6d12VtNfjNEaPOY4K8 La9XmEdrMrh1SMXcQ8lMfMz2o7pplLeGFvNWwO0MU+ELxXYPbdWonaQiS tiFlXXcy1wLibfSb2tncL1WNcbmsjN5FNMYr0h1n3aH04SRQw6I7xrLqq 0rZMs5QN/WRG2A1wmTIgEaHjtNT5IOSSRQZhFwqKWUtZlOPLn4Eiu3q7x u3JYPddJ+vyEUVu4U/+3x8bbDBaoqgN0AR5g+GXx01jn6ldZs4w4srHu1 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="343259432" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="343259432" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2022 22:11:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="820073580" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="820073580" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 04 Dec 2022 22:11:10 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 4 Dec 2022 22:11:09 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 4 Dec 2022 22:11:09 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 4 Dec 2022 22:11:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/VNnkiZjXpIMFNwciehCj7Xih14ZuYaEp1DVLHtFWAOQ7tqgvhhzh93/VixoFm6vtI4dxkA09VNJBU6C4wexygHB2yBgiTTreo6ukKqbZPbMvowOtQIkmRDKrgJn7NZ+ISEMQ9VRhGU3Qtp2Fd8u7YhEVGQrDJMQVGmPv4ufnfP17VJZl/B+M34kJdDOH+8v6/1KJ486TgQLvKm1cwTZCDmoG+RArvnBCBbOq0MwSP7lCS2DeLalzOGsPsmb3FX7oc2GBvjLFsYCo9eHud6vdU2jXSz1utb5ykay4amlR1k36kw16dBCrf7xKg64teXxglftmT3G6/GdRxq0MZiPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mv7e2qJ0//R30dlKMwiPNAhJ3qdA8PxTPKRgBXCFstk=; b=l50uZip6ZTMcXPafipcrXsMCBEWtFmmtEJwbtKkHg2NFLDXp8ezNflJDe6Fpux/vsdu+fK4gpBxoJaXYAdDSiPEK2k8kUqZ8rARFW5cnPLy44FjfA8U7sSwQb066G6rabNJxCFD0jYw4ZTLknOc8GpEiWXCutBUW5zUYkQGZv9v/g7t6C2L/9KyxWSpIojRQ+s5awAq6kvWM1kfh6SYufeYfYMTKyz1jsGzc8+kR4zENclFSkuWqMbfNdhqOT0C5JBYscvHkjI6UvnoKtwlqu2WKqUgaaesHYZLCZB90aqwRQYNRhMmoWJXC6DB/WguWbgtiO3jI/Zq3xLwHKULhxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by DM4PR11MB6141.namprd11.prod.outlook.com (2603:10b6:8:b3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Mon, 5 Dec 2022 06:11:08 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::27dc:d5e0:94b2:6e9b%3]) with mapi id 15.20.5880.011; Mon, 5 Dec 2022 06:11:08 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax Thread-Index: AQHZBVz8uoTLZ5IEzUOAI4bYPPYwYa5Z1q2AgAT/SYA= Date: Mon, 5 Dec 2022 06:11:07 +0000 Message-ID: References: <20221201081408.2194579-1-fei.w.wang@intel.com> <20221201081408.2194579-3-fei.w.wang@intel.com> <53dede11-325c-9b58-e447-420c6b470044@gmail.com> In-Reply-To: <53dede11-325c-9b58-e447-420c6b470044@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|DM4PR11MB6141:EE_ x-ms-office365-filtering-correlation-id: 5e912c4b-8cfa-4896-3724-08dad6877fe1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 46Kf5gZi7G4EMcocETwWFj6DIVfahZ/RUbQdh1nGf1Nd8cgq1Dslbo94s3AemxB3hc7/XycFs5Ze87soEIpvlWkz8ieWPthKPCs3v26y56EKFq0lkYrtzj7oCvZ+fsQGMxdJ1RpgW8Atd3iRje5sSA+M9MAcL7j3pr3kCiwthhLa6UGOY35vb6cVQfA1BM75Sf7hYdy8Zdf/6uqYzlvlIabHmfgAiu3sBS5kYbxAnlQrpNCDV6EK7eaC+LbqWcbJQVf5nRcmTBQFRbgRDkAbi7yedURz8mcRNvA7aRZQdHyR0Tu3DApo3JrjYjprSoq4kEqRLtc9IhetBTgwgVjEkYQCfeHL1zLmhMV3RhIzl2XIhd8f6PE5BQvDRkPwAPZN6185CyR1S7W1wQBW4KeLip04rNVxeJJVVL3hp+4pnQAHQiZGkKODAZUrTarKWTFs1cqVjYCGk5DtEXgLmY38LsRxWTosIV89XlIaTp7UNpxkUwlsJVqG4F3vwKWQ7sAmNPL0091zSloPRuJrI7Kb+0OZyD246s1oHdoaCQjOTZnCbsJevFopaP9HFjwCRi3yft/NI6QAQqxfxcU+NUpvEbsD1D4hpyaUDBr6j8zlAXKoZjcuiAFpD4LuVF3bbj0Z2TXcdNV42B9Apyl4nhQxFXdZHQz4IgHe002Tq18yGtXY8hAhfgEVqCDSotbjDfqtZWf+mX3vyUdheDT0+dXPMBRKxLRRZynb0oKQg4veUFg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(396003)(346002)(136003)(376002)(451199015)(36756003)(66899015)(82960400001)(38100700002)(86362001)(5660300002)(2906002)(41300700001)(8936002)(38070700005)(83380400001)(122000001)(91956017)(66946007)(66556008)(66476007)(66446008)(76116006)(478600001)(6486002)(966005)(316002)(2616005)(6916009)(71200400001)(8676002)(53546011)(64756008)(186003)(6506007)(26005)(6512007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OXF2bzRXYXVPajVNdEFnN0FlL00vZTR3M05ST0UrdDNDNlZ3bmZaWDJkR2pm?= =?utf-8?B?SWhvVXpjL1lkNVFlUDdHSmVYZ0hlaFFUTlhZamNVakxXd0ZIR2pTcU9mbDBP?= =?utf-8?B?TEJJRmJjdHBMbU1Wa2RlTzB5RFVMSGg3dTJHYWJuYzJrWkJSVXRXcVZoNEti?= =?utf-8?B?WkVuNm5RZVc2QzEwbGhNSitvTVZYM2p0OUFVcUx0OFVML0JIN3V0SVZUN0VL?= =?utf-8?B?RzFyY2VvdjdDb05hUXpJQk9KWE1zQzNycjR4eEdUMkVoYXAzUy9VRnZKajRl?= =?utf-8?B?aGd5TEJSTWx2VnpLVk01a1pRSnZnU3NpZjJ3aUh5bmdzSmJ3akFPc2dTT0Zh?= =?utf-8?B?T2FDMklmckRNaDFsMGRBNkh6REpIc0dmczBhZGM1UU1GbnRZZm1ybld4ZUJq?= =?utf-8?B?WlNpSjREbFBidi8zR0tSVGErMm1JZnhxVFMybXdubUVIWW45bGEvd0t5RVFy?= =?utf-8?B?VjMweTU1SzgreUJvODhaS1dna1hXSDJ1blc2anNhZnVacVpjNnU4aUFkRUMx?= =?utf-8?B?V2hZMCt5cCtzUkFrMkUrNUJ0QUdmYTFuSXBGaDN6aGZ4R0ZVWWNKN1RKUnNZ?= =?utf-8?B?VGxDNFoxUFZ3bm5ZbEZtSklDcGhTaEJmNzVpampLRWVYOE8vQTgyVFlja04r?= =?utf-8?B?ZE9CV2tqMURVQUluVjk0MUNHTDdmWXNZdjByaG5TY3FGYi9OZUo5QXNIT0Zo?= =?utf-8?B?bjVSOVV2Y0tpY1p5aFFMbnljZEJodUJVbFRYLzB2OS9ZbVV2TXhRN2JaOWxz?= =?utf-8?B?S3NoNTBLZHRlR2tacURLWm9jaXRSd1JvdE5YWURQdmFra2sxU0N3cmhMeDBt?= =?utf-8?B?SU1qeS9kUWQ5MjJHdmRIYVBCWHNXSnFVYlVyY21KR052TUdad0pTaDdUVkow?= =?utf-8?B?Uk5DaUFPUERtdjdHTkRhNmtkU0VPSEFPcTN0VlEvQzQ4WXBwSlZaalRyOW1L?= =?utf-8?B?MzlGWlE4b25iSDJUVE9aN010ZXdORHFyVzFPSVNuVWlaYmZKcmZUUExEMGE5?= =?utf-8?B?STBwL1ZUcUorNmxhQU0xZkVEWmRuWkZneUxNWGdoS25qL3lZWmVIcWc2UWpm?= =?utf-8?B?N1JIZEtkMDc3QkYxS2J5R3dzVmNHRk4rdUVxdDMzaDBacEdDc1p5Ylo0WW9s?= =?utf-8?B?R1JFNFBQeWlST2lQVUhBZkxoUjlDZlN1MXlFNTlnMDlha2hxUWYzSkpLZ29B?= =?utf-8?B?YVlBVXBlaURCS21yTXY4b1FMMzFsZDdpS0ZGNmRISUlHQlZ5RGVkeU1wTGNa?= =?utf-8?B?TENhekdYTElBZVZqMTR1YnlxNEVwUDd6R0dHdjRVZzBtNHoxZTcvOUZ0UGoz?= =?utf-8?B?a0RqSVA1dDl2NVpSQmI1VjRwOFptQkFyckZzQjZnWTZ2R0o1NFFuM2FEb1Rj?= =?utf-8?B?a0phUUlTWjRrWkVZeW9xb3VPdk9SeS8wSStwbTdCQ3FicUpzK1M2VHpYL3dS?= =?utf-8?B?QktBMWRUbVp6WUFmTkJJd2pjOHVKdkJKZ09Dc0ZVVXgzVzh3UEJ1Y21UOENT?= =?utf-8?B?MHNZV3U5eFRnZ3Z3Q1UxM1pJOVltMWl6WW84eVlQN3dORDJ3WDlabHh6QnFn?= =?utf-8?B?Vld2WmEycE9XZkdac25OTGtQUEF5TWlyblJmQWNHNkRRSXVvdU9QN0MrZlp2?= =?utf-8?B?VlkwZXBjbFVBbytkYXhaL05wK3QyQjJFZHlPa3JkaW5KdW1QTDhTeVh1WnZx?= =?utf-8?B?MEJMVkFHeDEybEJCekE5T1JuVXVuV0M0eVIzaXVRbW9XTTdFUXVpbWJlMUhU?= =?utf-8?B?R3pQSy9sRkp4U0FsMjhQMUtmMEpYRTBlYnY3TFZpV2FOcm00QWU2MTgxZnBv?= =?utf-8?B?M05Semsza2hTQWhUcVRTZ1R1QlJDN0l0S2psWjR1ek1YVkJTZmx4ZDk1aU5j?= =?utf-8?B?UCtKZHg1aG1FRE1GeVo5bERwelYrNVRIbU41UkFKS3Vya2ZGQzlheUIrQWlQ?= =?utf-8?B?dzg1ZnIwRWZ6RElBeWFrbW42TnlZSnUyT2VKODd5d1BpdXJhS2hvdng1NVVO?= =?utf-8?B?eEIvTXVKLy9qbmNrUS9pc0FCZmFvRE83c3lFNUt6T2ZkZWR4S1FEMWx4ejVJ?= =?utf-8?B?WWhmMUhqb0VwWGRlRXlZVE1HM2hjWCtwcWhjQU5vZFZiWTZxd3BERXVFdkp2?= =?utf-8?B?Y0pHNTBvQUFUZ2tHb1Z6NVpDZ0tEUldMTzhzQW5DZmw0V2tTSFVlbVBFYUFP?= =?utf-8?B?Q2c9PQ==?= Content-ID: <24D57D97C768BC48851959FE8B32E568@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e912c4b-8cfa-4896-3724-08dad6877fe1 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 06:11:08.0273 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IZV6g28gqlBagXzD1pBfridRPCnJKjeXXygX1K7a17ezt21GMvTqTf18YKzJxbvSSd6XPcd/VKc9bfp3dxiIyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6141 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-12-01 at 22:52 -0300, James Almer wrote: > On 12/1/2022 5:13 AM, Fei Wang wrote: > > +static void colour_mapping_octants(GetBitContext *gb, HEVCPPS > > *pps, int inp_depth, > > + int idx_y, int idx_cb, int > > idx_cr, int inp_length) > > +{ > > + uint8_t split_octant_flag, coded_res_flag; > > + uint16_t part_num_y, res_coeff_q, res_coeff_r; > > Use int or unsigned for scalar values in stack. > > > + int bit_depth_cm_input_y, bit_depth_cm_output_y, cm_res_bits; > > + int k, m, n, c, i, j; > > You can reduce the scope of almost all the above variables. > > > + > > + part_num_y = 1 << pps->cm_y_part_num_log2; > > + > > + if (inp_depth < pps->cm_octant_depth) > > + split_octant_flag = get_bits1(gb); > > + > > + if (split_octant_flag) > > split_octant_flag may be undefined here. It should be initialized to > 0. > This is probably the source of the issue Michael reported. > > > + for (k = 0; k < 2; k++) > > for (int k = 0...) > > Same for the rest. Fixed in V2. Thanks Fei > > > + for (m = 0; m < 2; m++) > > + for (n = 0; n < 2; n++) > > + colour_mapping_octants(gb, pps, inp_depth + 1, > > + idx_y + part_num_y * k > > * inp_length / 2, > > + idx_cb + m * inp_length > > / 2, > > + idx_cr + n * inp_length > > / 2, > > + inp_length / 2); > > + else > > + for (i = 0; i < part_num_y; i++) { > > + for (j = 0; j < 4; j++) { > > + coded_res_flag = get_bits1(gb); > > + if (coded_res_flag) > > + for (c = 0; c < 3; c++) { > > + res_coeff_q = get_ue_golomb_long(gb); > > + bit_depth_cm_input_y = 8 + pps- > > >luma_bit_depth_cm_input_minus8; > > + bit_depth_cm_output_y = 8 + pps- > > >luma_bit_depth_cm_output_minus8; > > + cm_res_bits = FFMAX(0, 10 + > > bit_depth_cm_input_y - bit_depth_cm_output_y - > > + pps->cm_res_quant_bits > > - (pps->cm_delta_flc_bits_minus1 + 1)); > > + res_coeff_r = get_bits(gb, cm_res_bits); > > + if (res_coeff_q || res_coeff_r) > > + skip_bits1(gb); > > + } > > + } > > + } > > +} > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".