From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 64DBD4DB67 for ; Fri, 28 Feb 2025 14:21:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B4E868DB60; Fri, 28 Feb 2025 16:21:22 +0200 (EET) Received: from efeu.mur.at (efeu.mur.at [89.106.208.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3753868DB08 for ; Fri, 28 Feb 2025 16:21:16 +0200 (EET) Received: from [192.168.4.116] (lan1.raspi.ma39.ffgraz.net [10.12.1.243]) by efeu.mur.at (Postfix) with ESMTPSA id 64C9046527 for ; Fri, 28 Feb 2025 15:21:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mur.at; s=dkim2; t=1740752475; bh=TLJDV2JLH83czOjaCqmsV/Az2su5dTAZVuQOITwvREA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=kqQUTv68wv1uUoGlMM0L4aHleyCY5dUsdhxA8ZUtcqtxSuREnalEKlptW2M/4d8PT 7vj0A/o0clemswBegKFsMSMmKQqV96hH1ru6nyspOHJZZHLLhrTahPuO0swOsx1UU+ jhVuUqRWo0V0NtEHK56o3GbNnQYgSxoWsMrhCQ091AOhShO9AGpb8pcEKE2cQOKVBb O1btzHtANemMTKCRO//toCiXVv6G8g+caRoJoo6BBnUiCHz/I4FILO4qLnYWDOxu39 uhUKzAHvtv5SzGyq58h4zaBgZKDGBPUC6gm5RIc4AJkdxj/lZsnGXr/xOpxhfgoqvo 09ko1WZOvcVfPtMahnQFeFGNbgSvHfGlT/OeZrJK/QPmtwcMSiGgP3HMdoHrry6sWX RKGzeTMZ0Z2XPjNx5F08H/Pep0y4VLhY7m7BVv2RNqJSZXPiHNhESgVN9yCOeEO/mA KAWzEbcSTh/VTdFt1AXliUNRVW1W6QXtF4yo2eFK/NzkcvRgv3p Message-ID: Date: Fri, 28 Feb 2025 15:21:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250227011054.3028508-1-michael@niedermayer.cc> <6D690464-DE4D-44B1-B851-44C855005FE7@gmail.com> <96fd7a0f-d755-4726-931c-c317a5f6d541@gmail.com> <20250228005859.GM4991@pb2> Content-Language: de-DE, en-US From: martin schitter In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/28/25 15:07, Devin Heitmueller wrote: > I've been working on the codebase for more than eight years, and > didn't know it existed. I would suggest that people reviewing patches > and rejecting them due to style issues that they recommend to > submitters to run the tool. In my experience, developers don't want > to have their patches rejected due to codingstyle issues, and such a > tool will help avoid such submissions in the first place, but only if > those developers know the tool exists. This kind of checks should better happen in some kind of CI based pipeline supporting direct feedback to the contributors before accepting the patches for any further human review by maintainers or on public mailing lists. That's why I really like GitLab and similar tools. And concerning bracket handling in particular: As long as languages do not simply enforce only one preferred coding style (like for example in rust and deno) you'll never find a solution, which makes everyone happy. martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".