Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

[martin schitter <ms+git@mur.at>]

On 2/28/25 15:07, Devin Heitmueller wrote:
> I've been working on the codebase for more than eight years, and
> didn't know it existed.  I would suggest that people reviewing patches
> and rejecting them due to style issues that they recommend to
> submitters to run the tool.  In my experience, developers don't want
> to have their patches rejected due to codingstyle issues, and such a
> tool will help avoid such submissions in the first place, but only if
> those developers know the tool exists.

This kind of checks should better happen in some kind of CI based 
pipeline supporting direct feedback to the contributors before accepting 
the patches for any further human review by maintainers or on public 
mailing lists.

That's why I really like GitLab and similar tools.

And concerning bracket handling in particular:
As long as languages do not simply enforce only one preferred coding 
style (like for example in rust and deno) you'll never find a solution, 
which makes everyone happy.

martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".