From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D097944E4F for ; Sat, 26 Nov 2022 02:34:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A94968B3E1; Sat, 26 Nov 2022 04:34:56 +0200 (EET) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D2E9F68AEB2 for ; Sat, 26 Nov 2022 04:34:50 +0200 (EET) Received: by mail-oi1-f177.google.com with SMTP id v82so6157551oib.4 for ; Fri, 25 Nov 2022 18:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L6bzJszWbfThfcYM98AVoNmNMZe56tSyjFLBd1C3etw=; b=AtU/+ArnH4kqZ5JHfSXKYfPRw1fkvx+L770l3TQBgrtgS9eJmLoSEC6wipHQEv7b8h d2VAp07DSOMAtQWQvqY7Q+57HMFUQrMlhROMKW+Cj46LqUbOa9eqxt0yAxe1blEOIEVM 8/HMR4a4q3T1sPaICp92c4/P6G2Js/haub8SHLrkWOT9WwAJIu8pjHoCH6mYrnLd80ca BZ8C101QmdtwOL6UX9PczC/AR6rVCg1VCvFhYbT/7BER20MpB+NHjFrgqHgUCcwAhyxq qXxoOMtAuIUeCcJHra+nPV3R0Z78gXnb+iXkw0bIlLb1igs1BZryYHUsg2b92FvoB/Nd Vc9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L6bzJszWbfThfcYM98AVoNmNMZe56tSyjFLBd1C3etw=; b=EeZOsqh7aDvwR8XDXFk7eSqTCujpuPnxB6PtPdwy9ztuc1F9HBnGLNdasnRBUTRwFY gIg37y/tTzNALgILGr5Tb37r51kRmgP858sFquWM64enQSnk8U7S1oQx53lBwWIJD0Cl v0sfh8UgK3PGB2g/ZVFF+Yl7EU3ykarI+3pSVTtQ5R+3zQlmoCDmDKf97Z2itXg0izrd c2JYuIY79mjue1grriMGa77rDrHA77o4Rbuo0dezK6AocSmg4zPbaO8zHBKPbKAgfEQy jDYBvU56OlVyK/hse4FxZtWKLuEGJt8Uw1d/mRVrwa+86USVRTzaEc/d09FqfG3An9G4 h9Pg== X-Gm-Message-State: ANoB5pl4cgi/Ek1kFCloeAb+t/pRfiFNxHkk7zeMPVFl5zWlWMJLyVMJ /gqiB/txjs0hOAAwLfOW3vmFRzrTTTk= X-Google-Smtp-Source: AA0mqf7bChajBx14IdXyHKVoY0dAJkClEOJg0Kc6ccLZh03NK8sK4sepusEQmvLCrw9RsYPShUz26w== X-Received: by 2002:a05:6808:a0a:b0:34f:bcdf:b08f with SMTP id n10-20020a0568080a0a00b0034fbcdfb08fmr10529246oij.71.1669430088924; Fri, 25 Nov 2022 18:34:48 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id g8-20020a4a6b08000000b0049f44db7b41sm2136717ooc.5.2022.11.25.18.34.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 18:34:48 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 23:35:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221124052209.520239-1-haihao.xiang@intel.com> <166938393779.4503.7930861168279237996@lain.khirnov.net> <12d8e532-f236-83b8-61cf-6c9ee72b10ee@gmail.com> <4bcec8d4-8593-9a23-3130-8aa52b1f3c11@gmail.com> <494bbc9b-ab82-0c62-f471-3ac9be03e80a@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support P010 format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/25/2022 11:31 PM, Soft Works wrote: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> James Almer >> Sent: Saturday, November 26, 2022 2:01 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't support >> P010 format >> >> On 11/25/2022 9:58 PM, Soft Works wrote: >>> >>> >>>> -----Original Message----- >>>> From: ffmpeg-devel On Behalf Of >>>> James Almer >>>> Sent: Saturday, November 26, 2022 12:58 AM >>>> To: ffmpeg-devel@ffmpeg.org >>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't >> support >>>> P010 format >>>> >>>> On 11/25/2022 8:51 PM, Soft Works wrote: >>>>> >>>>> >>>>>> -----Original Message----- >>>>>> From: ffmpeg-devel On Behalf >> Of >>>>>> James Almer >>>>>> Sent: Saturday, November 26, 2022 12:35 AM >>>>>> To: ffmpeg-devel@ffmpeg.org >>>>>> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_h264: don't >>>> support >>>>>> P010 format >>>>>> >>>>>> On 11/25/2022 8:26 PM, Dong, Ruijing wrote: >>>>>>> [AMD Official Use Only - General] >>>>>>> >>>>>>> Will it make sense to accept P010 input, however encode to h264 >>>>>> 8bit? >>>>>> >>>>>> If it works (the encoder accepts the 10 bit input even if it >>>> encodes >>>>>> it >>>>>> as 8bit), then i don't see why not. I assume it would also be >>>> faster >>>>>> than using swscale to convert said 10bit input to nv12 before >>>> passing >>>>>> that to the encoder. >>>>>> >>>>>> Removing support for a pixel format as input in an encoder needs >> a >>>>>> reason other than "It's rarely used", more so when it's a single >>>>>> line. >>>>>> It either needs to not work, or somehow get in the way of >> further >>>>>> improvements. >>>>> >>>>> Oh sorry, I noticed that there was a misunderstanding. >>>>> >>>>> When I said "It's rarely used", I didn't mean that as a >>>> justification >>>>> for the removal, it was meant as an explanation why none of the >>>>> hwaccels has implemented it. >>>>> >>>>> softworkz >>>> >>>> Alright, then i'll repeat my question: Does it work? >>> >>> No. >> >> What does this encoder currently do when you feed it p010 input? What >> does it output? > > An error: > > > 1. 10bit from HW context: > > > [graph 0 video input from stream 0:0 @ 000001dc301aeec0] w:3840 h:2160 pixfmt:yuv420p10le tb:1/60000 fr:60000/1001 sar:1/1 > [auto_scale_0 @ 000001dc2362a700] w:iw h:ih flags:'' interl:0 > [hwupload@f1 @ 000001dc2944ef00] auto-inserting filter 'auto_scale_0' between the filter 'graph 0 video input from stream 0:0' and the filter 'hwupload@f1' > [auto_scale_0 @ 000001dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > [AVHWDeviceContext @ 000001dc444f9a00] D3D11 Init > [AVHWDeviceContext @ 000001dc444fab80] D3D11 Init > [vpp_qsv@f2 @ 000001dc22a3d880] VPP: input is video memory surface > [vpp_qsv@f2 @ 000001dc22a3d880] VPP: output is video memory surface > [auto_scale_0 @ 000001dc2362a700] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > Last message repeated 2 times > [h264_qsv @ 000001dc161b6040] Using input frames context (format qsv) with h264_qsv encoder. > [h264_qsv @ 000001dc161b6040] Encoder: input is video memory surface > [h264_qsv @ 000001dc161b6040] Using the average variable bitrate (AVBR) ratecontrol method > [h264_qsv @ 000001dc161b6040] Current pixel format is unsupported > [h264_qsv @ 000001dc161b6040] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. > Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height > [AVHWDeviceContext @ 000001dc444f9a00] D3D11 Uninit > [AVIOContext @ 000001dc16197c80] Statistics: 0 bytes written, 0 seeks, 0 writeouts > [AVHWDeviceContext @ 000001dc444fab80] D3D11 Uninit > [AVIOContext @ 000001dc161839c0] Statistics: 131146 bytes read, 2 seeks > Conversion failed! > > > 2. 10bit from SW context: > > > [graph 0 video input from stream 0:0 @ 0000019e915dee00] w:3840 h:2160 pixfmt:yuv420p10le tb:1/60000 fr:60000/1001 sar:1/1 > [auto_scale_0 @ 0000019ee99936c0] w:iw h:ih flags:'' interl:0 > [format @ 0000019ee9993240] auto-inserting filter 'auto_scale_0' between the filter 'Parsed_null_0' and the filter 'format' > [auto_scale_0 @ 0000019ee99936c0] w:3840 h:2160 fmt:yuv420p10le sar:1/1 -> w:3840 h:2160 fmt:p010le sar:1/1 flags:0x0 > Last message repeated 3 times > [h264_qsv @ 0000019ee9995dc0] Using device qd1 (type qsv) with h264_qsv encoder. > [h264_qsv @ 0000019ee9995dc0] Encoder: input is system memory surface > [h264_qsv @ 0000019ee9995dc0] Using the average variable bitrate (AVBR) ratecontrol method > [h264_qsv @ 0000019ee9995dc0] Current pixel format is unsupported > [h264_qsv @ 0000019ee9995dc0] some encoding parameters are not supported by the QSV runtime. Please double check the input parameters. > Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height > [AVIOContext @ 0000019ef62b4000] Statistics: 0 bytes written, 0 seeks, 0 writeouts > [AVIOContext @ 0000019ee995abc0] Statistics: 131146 bytes read, 2 seeks > Conversion failed! > > softworkz Alright, thanks for testing it. The commit message should mention the pixel format is being removed as it's unsupported, then. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".