From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Fix build failure from channels API
Date: Tue, 15 Mar 2022 19:45:36 -0300
Message-ID: <aab6b976-f265-3260-8379-c66642e83087@gmail.com> (raw)
In-Reply-To: <20220315223444.3449-1-michael@niedermayer.cc>
On 3/15/2022 7:34 PM, Michael Niedermayer wrote:
> Regression since 2f8ccca2fa94ce256ff77baa18f462c1abd8d2cc and surrounding commits
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> tools/target_dec_fuzzer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c
> index eaa26b0e62..3bd1eff3ce 100644
> --- a/tools/target_dec_fuzzer.c
> +++ b/tools/target_dec_fuzzer.c
> @@ -47,6 +47,7 @@
>
> #include "config.h"
> #include "libavutil/avassert.h"
> +#include "libavutil/avstring.h"
Why?
> #include "libavutil/cpu.h"
> #include "libavutil/imgutils.h"
> #include "libavutil/intreadwrite.h"
> @@ -273,7 +274,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
> extradata_size = bytestream2_get_le32(&gbc);
>
> ctx->sample_rate = bytestream2_get_le32(&gbc) & 0x7FFFFFFF;
> - ctx->ch_layout.channels = (unsigned)bytestream2_get_le32(&gbc) % FF_SANE_NB_CHANNELS;
> + ctx->ch_layout.nb_channels = (unsigned)bytestream2_get_le32(&gbc) % FF_SANE_NB_CHANNELS;
LGTM, sorry about the breakage.
> ctx->block_align = bytestream2_get_le32(&gbc) & 0x7FFFFFFF;
> ctx->codec_tag = bytestream2_get_le32(&gbc);
> if (c->codec_tags) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-15 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 22:34 Michael Niedermayer
2022-03-15 22:45 ` James Almer [this message]
2022-03-16 0:33 ` Michael Niedermayer
2022-03-16 0:37 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab6b976-f265-3260-8379-c66642e83087@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git