From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 673674F4D9 for ; Thu, 26 Feb 2026 18:50:27 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'ugVKZ1U9XfMxdspN+UIg3xD0YFmbxOTYbPCPDilLfEM=', expected b'3Iju7TUdwiOTsi9dn3wsSEJaloBKL14/NBCY6CyVG28=')) header.d=niedermayer.cc header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772131808; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=wghYIsHlfZMQN5P9lL5+lqoswHaNwavFdipxrK7OZKU=; b=SE1KIDXLbMqcDkjFYp5rgXUizzEefiWDPwWeMAbatrv6hqbuCJbPWDCUFJ3n9RfObzFNu bgcOq8/quIFP7tfKxV/rnXq9w6sV2jui6eqL3y63I9N1GQAGxJLGSPHsS+VPdEnFduODe3X ZcBinM0VTS+c5EzJZKSAskF7PO/hFpqm9jIGbS2rfu5sBzxQoxQ+oLOfxww7FCARltPPg/6 9ft2Ue3O2EnhUXILKw8Z+IvjzJ3W4SZb8upTa5Nukigo1qWitDlrIqrvcRtGcG8Yid26Pkh ofRu/BqeYj0XtZFlgxmpkfqqvSEtz7k5N0b5cCdqAhNxcLk1oRFT+jKC4Bvg== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6CE5C691316; Thu, 26 Feb 2026 20:50:08 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1772131800; b=chTcHnDqq5xgv025RKnJ7c38/I97FB7nwl5Qs2hyMjQbWarrUwWKNw7i4jfJf39yv5RXo l+A0YsHmoO9I5eMkTeAnhlS+nhAkz7lmJ52w4LMoD28MEJkBMD3Vzbl7s154y9o33aCn3Sh O/mKIdBhnCqv95JPpeNvye/Mnwt62yMIf9UZH7Pn0GVu4r+Gkvmmn4qK3cEt4TATwjY2HBR 82rEH4gKj4zp62c6wJVKI1BAEdUUcf6Gulquwp4+0eRm+tobYdTvPYJlfJd7AnTye2qMp5s ZdMFvWJ4VvxMlmysF3hiScJJk8zFckSFw6mJjlQraWtu6x/iWCXymhjUO93g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1772131800; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=ugVKZ1U9XfMxdspN+UIg3xD0YFmbxOTYbPCPDilLfEM=; b=g0nMySahyIwrLQr6d3tqZY+2W/OMsArCuIAs9S/NzIxX+UzhoElRysOAERes95ClFzYip PEmVa7/HU1dF1e5KzB+bAABVYk6Rags2alN4wXxjH6K4fMqFemXgG8AKREVMEK0X9ljNe/R 16vUirzAJykghScUbUZy15nayhUqvL9S9u/zv0zougPfxXDcRD5ucO6u9JmyWQlr/5KORcb O/onIOfAnJEQyDBY/U4zrtKGvDHWi9u1pmNJStYVfACVJv/UIoHARTH8pYcn+H7W7bkhWru dRbEXIK5NZ/jZ6HCyjZKk7k59Xwdy8Pn8Lg3PEsq34seJsig23MU6rv41FLQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none (Message is not ARC signed); dmarc=none Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E9B3B691293 for ; Thu, 26 Feb 2026 20:49:45 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2BAA9444A3 for ; Thu, 26 Feb 2026 18:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1772131785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Iju7TUdwiOTsi9dn3wsSEJaloBKL14/NBCY6CyVG28=; b=kMFcJ0NPeM8oFC16GaRu2hs+Ix/6gYX7c5nZJZdJOxHw61wQym8p6EGb7wJ4zr0RIpmtGz vp2TaxbQBy1nBjYcy6GL0jX0sW9TyJdtBmUnf99Pk0IrXwtpi8Fygv8DTPdD812nghLLcZ FNWauqKunu1MiGBUBsu+FwaacZzD9Syjvt7HY1+VxOBC2wlsIao+F1K/FXeKQ/hfR7eMUF PP9amrAz9mVmdix8HzG4XHuIO5Xhr8dLALrx25phzQSdmNThaHKt0isE7HNqlKkZ1kqOP6 Kvgj1ku87VfM9q+JPKcx2am4NMFStu04DfpUFGafEkXeJtIHRkdp/Ra9PpQ3yw== Date: Thu, 26 Feb 2026 19:49:44 +0100 To: ffmpeg-devel@ffmpeg.org Message-ID: References: <177210096710.4171556.3578656131562835305@ffbox> <20260226101608.82F5269120F@ffbox0-bg.ffmpeg.org> MIME-Version: 1.0 In-Reply-To: <20260226101608.82F5269120F@ffbox0-bg.ffmpeg.org> X-GND-Sasl: michael@niedermayer.cc X-GND-State: clean X-GND-Score: 10 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeeikeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecufghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeffledtfeevfeffheeuuefhtdejieelueeftdeitdfgheetgefffeefteekffdthfenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeiiedrhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieeirdehtddphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhqihgupedvueetteelgeeggeetfedpmhhouggvpehsmhhtphhouhhtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Message-ID-Hash: 4NHLLW4FN6ZQVNETT3U3SUQKQDJI363A X-Message-ID-Hash: 4NHLLW4FN6ZQVNETT3U3SUQKQDJI363A X-MailFrom: SRS0=7dxx=A6=niedermayer.cc=michael@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [FFmpeg-cvslog] [ffmpeg] 09/09: swscale/unscaled: fix rgbToRgbWrapper for YUVX List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michael Niedermayer via ffmpeg-devel Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============8517930337594409945==" Archived-At: List-Archive: List-Post: --===============8517930337594409945== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LzDWIovb+MrUJj2v" Content-Disposition: inline --LzDWIovb+MrUJj2v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi this breaks brender =2E/ffmpeg -y -i 5-0-TESTMAP.PIX -vframes 1 /tmp/brender.tga colors look very wrong https://samples.ffmpeg.org/game-formats/brender/brender_pix.tar.gz thx On Thu, Feb 26, 2026 at 12:16:16PM +0200, Niklas Haas via ffmpeg-cvslog wro= te: > This is an automated email from the git hooks/post-receive script. >=20 > Git pushed a commit to branch master > in repository ffmpeg. >=20 > commit 5fa2a65c110a942acba211ac3e6690ef244c8e9e > Author: Niklas Haas > AuthorDate: Tue Feb 24 19:01:05 2026 +0100 > Commit: Niklas Haas > CommitDate: Thu Feb 26 10:15:52 2026 +0000 >=20 > swscale/unscaled: fix rgbToRgbWrapper for YUVX > =20 > This code calculates the pixel step using c->dstFormatBpp, which is w= rong; > should use the pixdesc step instead. (dstFormatBpp is 3 for YUVX, but > the actual pixel step is 4 bytes) > =20 > This bug was mostly hidden by the fact that the same bug actually dis= abled > the fast path for the (common) case of strStride =3D=3D dstStride. Un= covered while > making changes to the swscale.c allocation code. > =20 > Reproduced by modifying libswscale in such a way that the dst buffer = stride > happened to be exactly 4/3 larger than the src buffer stride, e.g. by= adding > extra padding to each dst buffer line, but reproducible in principle = by any > API user. > =20 > Signed-off-by: Niklas Haas > --- > libswscale/swscale_unscaled.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c > index 38a9b467d4..f612f88c4d 100644 > --- a/libswscale/swscale_unscaled.c > +++ b/libswscale/swscale_unscaled.c > @@ -1994,8 +1994,8 @@ static int rgbToRgbWrapper(SwsInternal *c, const ui= nt8_t *const src[], const int > const enum AVPixelFormat dstFormat =3D c->opts.dst_format; > const AVPixFmtDescriptor *desc_src =3D av_pix_fmt_desc_get(c->opts.s= rc_format); > const AVPixFmtDescriptor *desc_dst =3D av_pix_fmt_desc_get(c->opts.d= st_format); > - const int srcBpp =3D (c->srcFormatBpp + 7) >> 3; > - const int dstBpp =3D (c->dstFormatBpp + 7) >> 3; > + const int srcBpp =3D desc_src->comp[0].step; > + const int dstBpp =3D desc_dst->comp[0].step; > rgbConvFn conv =3D findRgbConvFn(c); > =20 > if (!conv) { > @@ -2004,8 +2004,8 @@ static int rgbToRgbWrapper(SwsInternal *c, const ui= nt8_t *const src[], const int > } else { > const uint8_t *srcPtr =3D src[0]; > uint8_t *dstPtr =3D dst[0]; > - int src_bswap =3D IS_NOT_NE(c->srcFormatBpp, desc_src); > - int dst_bswap =3D IS_NOT_NE(c->dstFormatBpp, desc_dst); > + int src_bswap =3D IS_NOT_NE(srcBpp, desc_src); > + int dst_bswap =3D IS_NOT_NE(dstBpp, desc_dst); > =20 > if ((srcFormat =3D=3D AV_PIX_FMT_RGB32_1 || srcFormat =3D=3D AV_= PIX_FMT_BGR32_1) && > !isRGBA32(dstFormat)) >=20 > _______________________________________________ > ffmpeg-cvslog mailing list -- ffmpeg-cvslog@ffmpeg.org > To unsubscribe send an email to ffmpeg-cvslog-leave@ffmpeg.org >=20 --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Whats the most studid thing your enemy could do ? Blow himself up Whats the most studid thing you could do ? Give up your rights and freedom because your enemy blew himself up. --LzDWIovb+MrUJj2v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaaCVxAAKCRBhHseHBAsP q1QlAKCIxn+gxCwzerK6RTFtf1surk7tRgCeKl4Wyw9R7Sa4HKSM4fTqSgeM5XQ= =qyGR -----END PGP SIGNATURE----- --LzDWIovb+MrUJj2v-- --===============8517930337594409945== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============8517930337594409945==--