[FFmpeg-devel] Re: [PATCH] lavfi/mpdecimate: fix three bugs in keep_count logic

[Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Dana Feng via ffmpeg-devel (HE12026-02-25):
> Thanks! Is there a way to get it reviewed / merged? I opened one here: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22261

Hi. The person who sent you to forgego (who, afaik, is not a regular
FFmpeg contributor) wasted your time: there are no more people capable
and willing to review your patch over there than here. In fact there are
at least one fewer such people.

I do not know if I can gather the motivation to review this patch, my
personal energy has been utterly crushed in the last two weeks. But I
can try a few comments.

It would be helpful to have test-cases, commands to show the difference
your patch makes.

Also, it seems your patch makes three related but independent changes.
Could you split them into three successive patches? That makes it easier
to verify that each change is for the better.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org