From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000: Simplify exp2fi for numbers used here
Date: Mon, 19 Feb 2024 15:51:28 +0100
Message-ID: <aa5289158a3caf8edcc9d71c49c10c9869d85905.camel@haerdin.se> (raw)
In-Reply-To: <AS8P250MB0744FFE411F92F5E4EB8AFA68F512@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
mån 2024-02-19 klockan 15:14 +0100 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > lör 2024-02-17 klockan 21:05 +0100 skrev Andreas Rheinhardt:
> > > The call to ff_exp2fi() here always uses arguments in the normal
> > > range, so that the branches in ff_exp2fi() are unnecessary.
> > > This is so because JPEG2000 itself only supports up to
> > > 128 bits per component per pixel (we only support far less);
> > > furthermore, expn is always 0..31 for the decoder and also
> > > sane for the encoder, so that the difference between these
> > > two values is always in the normal range of -126..128.
> >
> > Any measurable improvement in decode speed?
> >
>
> I don't think it is measurable; my aim was to move ff_exp2fi() out of
> internal.h (where it does not belong).
Ah. Well, fewer branches is almost always good so, looks good to me.
Maybe pal has an opinion?
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-19 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 19:54 [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec, j2kenc: Constify where appropriate Andreas Rheinhardt
2024-02-17 20:05 ` [FFmpeg-devel] [PATCH 2/4] avcodec/jpeg2000dec: Avoid using GetByteContext.buffer directly Andreas Rheinhardt
2024-02-19 14:00 ` Tomas Härdin
2024-02-17 20:05 ` [FFmpeg-devel] [PATCH 3/4] avcodec/jpeg2000: Simplify exp2fi for numbers used here Andreas Rheinhardt
2024-02-19 14:09 ` Tomas Härdin
2024-02-19 14:14 ` Andreas Rheinhardt
2024-02-19 14:51 ` Tomas Härdin [this message]
2024-02-17 20:05 ` [FFmpeg-devel] [PATCH 4/4] avcodec/internal: Move ff_exp2fi() to aacsbr.c Andreas Rheinhardt
2024-02-19 11:30 ` [FFmpeg-devel] [PATCH 1/4] avcodec/jpeg2000dec, j2kenc: Constify where appropriate Andreas Rheinhardt
2024-02-19 13:58 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5289158a3caf8edcc9d71c49c10c9869d85905.camel@haerdin.se \
--to=git@haerdin.se \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git