From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9245E424A3 for ; Tue, 24 May 2022 08:47:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7964768B54D; Tue, 24 May 2022 11:47:05 +0300 (EEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1CA8568B452 for ; Tue, 24 May 2022 11:46:58 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653382024; x=1684918024; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=pWubdTwgJOH7w2lrZKNLheqIm4BT4i2cCggHRmrATuk=; b=Hb84FL+irP19BIqR9djakN/cHt92bkpJ6L/UUDYixIC4QdeT9CTW2Bi/ 6iWbm0xr47aw0jIMgTVQuKNy6m17bKr3cASaONGU/NjQGnzVNnycV/FZq gEQ9dQWI/qs4PY5YNT/oBdZk3TdmAGs2rVffwk/WJDXDEAZX9UpZVqV94 S54ZvYIZIN7xXknH6WADWUoNrCJpTWMQ8XF31GT1H+N3Zm4ye2cjVbaya 4gTYCItndmx6IUzmbiWkfWRYPIb0BzsuLHE7kjhsapHUVLgKtbK/Zsg3F MSwKmlT/hE/QOQ9Wmt+KHVXO5Zwyl+C+1/6y8jUjPs+c/sJo/I97w3cGv g==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="334118678" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="334118678" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 01:46:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="572525146" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 24 May 2022 01:46:56 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 01:46:55 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 01:46:55 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 01:46:55 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 01:46:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXHF7aZvyZZGQweU6LjibcXic9Zq63SLQEED8LGfy+U/fDircMLNcimeoQZU96lINT1Y1zyYUEbY5rdh5YKPdDz8wHtNcydi0ml1DS2Zf8TxZl64/KaqJXqNngYbeG509u8qkghbIix9X2KYukcEziCi2oCKcH1TIfCTtk76nSfyAprUYLyUE67lUbzWOXX1a3HgIcFFi4IkdEwVCCa88eYKMbvWW9A+gcNXz2ZiD2gfmDUs9zyhW65eFfhi4vhObP7MFuF+kl97nSNusJDjfrOHHuXKt8PuFhRAtHpXSDUoVwUiRbKYbqpkVU6/mhPNHgjE7xzJ2grlbg0J55FxDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pWubdTwgJOH7w2lrZKNLheqIm4BT4i2cCggHRmrATuk=; b=C7CnhpI+cTfPwBRP2BPdwa0pcQSO/BYJIP70Z70ue4EkzPw19566D+WMRGiBfXzZXmyQgp5ya/WIyqFsJ/1c1Fv9Wv5IJcLHzgksHxUr+5HcO9sB6HCm7DecrAeutIo1QuNdsYSFaAK6vD71YWj555DrFUReLo4VmB9mqh9aF2cRFz0m7dwwMlzeqVfb+yIFQj8T9VvRu4zeQhizi2Vk5RAuPH3h9bTMrKmusFKIB9dbldIt8QKZ7UnwXDiGoELbH/Um3SyUaCEKePH8r2NVG4udVSFyFWgV/S1y9jACGbRYTHfmFFuz8wRJjhe5kQYNRIeeddWWuj2r8k8O+D8Zug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BL0PR11MB3057.namprd11.prod.outlook.com (2603:10b6:208:76::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Tue, 24 May 2022 08:46:54 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73%8]) with mapi id 15.20.5273.023; Tue, 24 May 2022 08:46:53 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" , "softworkz@hotmail.com" Thread-Topic: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx Thread-Index: AQHYbgcNaYm0JGsY0kyASXf+HIc8+q0tuZIA Date: Tue, 24 May 2022 08:46:53 +0000 Message-ID: References: <20220522121911.10993-1-haihao.xiang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46f8b7f2-833a-428b-7978-08da3d61f3d9 x-ms-traffictypediagnostic: BL0PR11MB3057:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ba4jJ3XbI+xxH0MUAHXvqv+qRH7iJbPu0pmIWwGej7Kj7C2x8UnIUqR2iB2oesgp5GD1qARaC1rW0oBstdiw32CMC1rbkFx8FmA8TWg+8iTMMOEg/ZUGeKDu2mCWHuTsD1syG0a1zFo+sMR/Fswgpg9nTBc3AQCPhZfkzkC5+kYCcRkLO5bEaAHOOHU+mH4sOckHqRumGI8PvuLioxhqEQ6JBlWh5A/DYdx0bdCL76WZyOQBjLcTcf7rvY5nHuTD7guJJtSpJjHDsEC3dzaPoe/jAy038y3HlQWYH9YBcAW/YZQBX6/D4iDjDSefW8YJ+g4GhUqpArwG4Bn8wAcJb2EMPJPeORto+dJLDW2rWC/JaiBCArlLCv40hbXxNHRFWvl5WP+i5cAh8n0CekcTRwv4UnWhiSKu29x8bO2qDP894LmqQkKjBrVwUFHCXI/PyUsC5fYZ+dt8DaYzuubMhzS/TBKgQt4jzA4QO4O3bGgTUAeTZNFMw81YrZqwCpO9Hctb2JfYP/1a7CW51KyYt9HZophR7RN2iuSK3JLW90PPjUVB/k/odBKTs69kfO5/QPnRI/cb3Chi5u5rl7tzzMkLor1hhwaNff4Ls5cxiFjEOkSI3Oif+2hlvbYwMY0NRoS1mAEUwIKny8knXA5BdeRAV3OL5bbHBoCvdBsNdbZQpPvmP7Fb8ckR5Q1+rUw/6eK4TyL9Kh9ZvzmYQ+tmQP6QMbUYDJ0IupxJFpSmQJo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(38070700005)(316002)(6506007)(110136005)(82960400001)(53546011)(122000001)(38100700002)(91956017)(508600001)(2906002)(86362001)(66446008)(66946007)(64756008)(66476007)(83380400001)(66556008)(8676002)(186003)(5660300002)(8936002)(2616005)(6486002)(71200400001)(76116006)(6512007)(26005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VjEyMU00a1FQaWJFZU0rRy9ORGxFdyswZkllTGtkbWpBMjcySGw0a3dnWGVV?= =?utf-8?B?OTZLNmdDaWtVRlYxUTRqL05LZjMwamxzRmhXbzM1Z2FNTmxRaFZYZXQzUkVq?= =?utf-8?B?K2ZOTklLNnI5Z0JMdEdjSUMrUEJSS3ovMmtYN0ZGeW1aSjdSWm50ZDh2QUgx?= =?utf-8?B?elpiclJlWHlVak12R3dkaVNYSTNWZXEvblNiOE5ianM1Tkhkai8vZHc2L05p?= =?utf-8?B?NkpJUlNPOTBZYWVUYjk2SDZSdmNHMzRONDRHWFowaHFSTGR5bDRDMTQrdmQ0?= =?utf-8?B?SGJWTC8vN3oxQXdneUh4YW91S3F1YmdrSWlBeDY3OFZ6eFV2Ui9mRTRRN2Mv?= =?utf-8?B?ZHFEbVNBV1dqQ1pyS3E3M3JBVVp5WUJDYk5ld3RoRXdyL211V2ZSL0Q5VlBw?= =?utf-8?B?ZVByZ2U2SkNkRmpyUGwzdjlDQmpzYlMxZWNEcW5uOG9uUkdXQlgyMzNMMlpM?= =?utf-8?B?VFMxRFJCSko4UVMycnVJUXdWOVhleUlrYXoyU1lBSVVXeUk1ZXpJdEhMbGJr?= =?utf-8?B?ZXgrd1RRMWVxaXVRM1pRVWd5QXEvSW01V3M3RVdraHBmSmsvbW1vdXpCUVdi?= =?utf-8?B?Y0Erb3l2Q01TWjRHWERGVC8vbmEzaHBocnI4RVJyS0Q4b3lDaEpMYmlRQ1VX?= =?utf-8?B?bGxVMW1IM2Mxb3VaMzZtVE5hb0lIaTZYM1BydUxSczVVREdiend2N01VK1Az?= =?utf-8?B?UEF0VnBwNk5ocGFLNXFUQnJrNmIxYUJwaXc1Qm9UUFZTT3dHMGd0RGo3VXVw?= =?utf-8?B?NkdOblEyWEphOHZiUUNhYk5pQXhTUWZlNkhrdVVpa1JJaFpBTys2aWZUWXJ3?= =?utf-8?B?TlBwWTRieTkwYnM2MVA4NEx0M1BMY3B2Y2hKTkpmWE5Id1FuWmFHaG9EbEVQ?= =?utf-8?B?Zmh3V0YvSmZHdHZXdEprTHdEWGUrNkRzeGEraGsweEtIeXNOanZYSlllc0da?= =?utf-8?B?Y0RUS2NMRVZ0TFhoVDlCV29VOEpMc2UzNmdjNWpBQVljT040dDlWM3ppeGNz?= =?utf-8?B?aHlBV0FiL3FKRkIwK21CUUUyMDRzcnRFOHlZamNZV0VWcUFWc3VNdFBxYkhS?= =?utf-8?B?ZUc2L3ZnWEVNbFlPc3R3WlJIMVVrUUU0azhDYnBiaVJURzNGNXBxV1MxaEw4?= =?utf-8?B?bkd4cjJGdmsvUUZlSnQzY1llTjVLVFJCbGVod0plTjhBSmU1WlZVWDcvVzRt?= =?utf-8?B?R002ZWRtTlNCS0liOVRjUUd2SU1FNTNPREZ0andhUURGRXdHOEV0UGNUUVNt?= =?utf-8?B?b1MyY0VZUVlDL3dGT3JPZ2dBd25XOWpvUzFvZGtJNWZqaUNpZTlKUml3V1Bk?= =?utf-8?B?OFdXeXcweE1BZUd1d2VaeGRZZEd3VEExbTgvSEJHSmM4L082Qk9QUzlrV29t?= =?utf-8?B?ZjJBcUlaUnNJS2htWUVaS1ErUFVtMGdGdjMvdFB4clhXYk5VOGs3K3ZVbVI2?= =?utf-8?B?V002MHhZVlM3VEFPUnJhYkt2VmQ5TXdlUHliS2t6RTludWdsdlluUjVuWSsy?= =?utf-8?B?ODVOelpqSW5CUWZMUysrODlYUHlpbFVNK08zZGZuZytHMGNQM0UwK0p1T1FK?= =?utf-8?B?Z20xaXRQbU14RWZzTkNsNUxCRnU4SFNmWnczeTRZLzVld3llVUxScnNEQkd2?= =?utf-8?B?eVIyaHF2NGFiSFhUcFYyRHdBQi9mR2tvQlN1eVg5cW83RDBnZnVQeC81YXZI?= =?utf-8?B?QXlaVGx4Z2FlZ1RuSGVSak4rc1ptNTU4UUoxdFNwbnVtTVVIVUt3NWFDa09D?= =?utf-8?B?elZ4aGNSU1dpbTNYSTc1RWJDdW9EQlF0dlE1RVN6WE1tdkpINml4UnFXeDdl?= =?utf-8?B?MDBCMDAwYWw3eDFUVkxTZmpiL2tuREViOXZiSWp3YmJBQmtvQlA5eW90dEht?= =?utf-8?B?dVRsM0toeHJwK0Z5bG96UTBUc2FYU3o0T0NXakJ1L2hsM1lHRnBSRkpLcnNr?= =?utf-8?B?RUJiSXcycjlDNGlRTXVwQ1RHSEVLWjhsVkY3U242OHRteWJERzdPM204OEJo?= =?utf-8?B?WDJiVGNKQUIwTGJ3R0lFTzB6NHpHckJTeGdkWlQ3QXBHU2hldlM4NmpXTWRW?= =?utf-8?B?Z2lDSThzbWpwdkw1SkZNMy9jNmZPM3N3dlRIajdrdTZ0ZEhic2JqSUNUOHBp?= =?utf-8?B?YS9LL1NXN1RyYzd2T3dNbDB1RDlUU0ZMV0YwRnV6ZUhrSFJ4TGxjSE1idUxG?= =?utf-8?B?RkNCaEdsak1jblFHZlhJQk9oWitURUNSQjZXVG5RdHlnT1BaL3lWbzVoNkc3?= =?utf-8?B?Y2hvZW05Tys5Z0RtZmJvaDZTT2N0dUM4eHcwQk9uVU9wcVU2SUhaanhINGx1?= =?utf-8?B?allOTzNwVi95MzdiUER1dnFTSlRDL0V5cVpHVWQwRlY0ejIxN1VCaXFFSjJq?= =?utf-8?Q?Og870NyjDIu+aeS8=3D?= Content-ID: <53C2ECFF18FA6B4993C404E1ACF52EB6@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46f8b7f2-833a-428b-7978-08da3d61f3d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 08:46:53.8428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yts2U+rnueyT4QKJKKHQLDlJfa8l1LFHO5auZPq7EeqNK9fdrXvmWdSBFcd/Wa1nkaa+vv4JuY8lHnrpDr7YIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3057 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Haihao > > Xiang > > Sent: Sunday, May 22, 2022 2:19 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Haihao Xiang > > Subject: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal > > version of libmfx > > > > libmfx 1.28 was released 3 years ago, it is easy to get a greater > > version than 1.28. We may remove lots of compile-time checks if adding > > the requirement for the minimal version in the configure script. > > --- [...] > > LookAheadDepth: %"PRIu16"\n", > > - info->ICQQuality, co2->LookAheadDepth); > > - } > > -#endif > > -#if QSV_HAVE_QVBR > > - else if (info->RateControlMethod == MFX_RATECONTROL_QVBR) { > > - av_log(avctx, AV_LOG_VERBOSE, "QVBRQuality: %"PRIu16"\n", > > - co3->QVBRQuality); > > + av_log(avctx, AV_LOG_VERBOSE, "ICQQuality: %"PRIu16"\n", info- > > > ICQQuality); > > This branch is now identical with the previous one. But I wouldn't > mind leaving it like this as it's better readable. > > Probably somebody will mind the curly brace formatting around else if, > though. > Thanks for pointing it out. I'll change it when merging the patch. [...] > > LGTM. This patch is a great improvement to the qsv code as it is dropping > a lot of old and unnecessary clutter. > Thanks for reviewing this patch. I'll applying it if no more comment. BRs Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".