Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx

["Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>]

> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Haihao
> > Xiang
> > Sent: Sunday, May 22, 2022 2:19 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Haihao Xiang <haihao.xiang@intel.com>
> > Subject: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal
> > version of libmfx
> > 
> > libmfx 1.28 was released 3 years ago, it is easy to get a greater
> > version than 1.28. We may remove lots of compile-time checks if adding
> > the requirement for the minimal version in the configure script.
> > ---

[...]
> > LookAheadDepth: %"PRIu16"\n",
> > -               info->ICQQuality, co2->LookAheadDepth);
> > -    }
> > -#endif
> > -#if QSV_HAVE_QVBR
> > -    else if (info->RateControlMethod == MFX_RATECONTROL_QVBR) {
> > -        av_log(avctx, AV_LOG_VERBOSE, "QVBRQuality: %"PRIu16"\n",
> > -               co3->QVBRQuality);
> > +        av_log(avctx, AV_LOG_VERBOSE, "ICQQuality: %"PRIu16"\n", info-
> > > ICQQuality);
> 
> This branch is now identical with the previous one. But I wouldn't 
> mind leaving it like this as it's better readable.
> 
> Probably somebody will mind the curly brace formatting around else if,
> though.
> 

Thanks for pointing it out. I'll change it when merging the patch.

[...]
> 
> LGTM. This patch is a great improvement to the qsv code as it is dropping
> a lot of old and unnecessary clutter.
> 

Thanks for reviewing this patch. I'll applying it if no more comment. 

BRs
Haihao



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".