[FFmpeg-devel] Re: [PR] libavfilter: split combined AVClass definitions into per-filter classes (PR #21681)

[Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

jbvsmo via ffmpeg-devel (HE12026-02-08):
> Several filters that share the same options array also shared a single
> AVClass with a combined class_name like "(h|v)stack",
> "(a)split", "kirsch/prewitt/roberts/scharr/sobel", etc. While
> compact, this causes ffmpeg -help full and the AVOptions API to
> report a single merged entry for multiple distinct filters, making the
> output unsuitable for machine parsing.
> 
> This patch gives each filter its own AVFILTER_DEFINE_CLASS_EXT with
> its actual filter name, while continuing to share the same underlying
> options array. The generated class symbols remain static, so there
> is no ABI or API change for downstream users.

I am rather against this. I remember efforts were made deliberately to
remove the duplication of the options array.

If your issue is to make the output convenient for parsers, then I
suggest you add an option “ffmpeg -help full-script" that does exactly
that.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org