Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <ffmpeg@haasn.xyz>,
	Michael Niedermayer <michael@niedermayer.cc>
Subject: [FFmpeg-devel] Re: [FFmpeg-cvslog] [ffmpeg] branch master updated. fd1fd5850d fftools/ffmpeg_sched: unchoke upstream nodes on recv-closed filter inputs
Date: Fri, 30 Jan 2026 16:45:16 +0100
Message-ID: <aXzSDNOVks6yhdVW@neo> (raw)
In-Reply-To: <20250930112036.4AD8768EDAD@ffbox0-bg.ffmpeg.org>


[-- Attachment #1.1: Type: text/plain, Size: 4403 bytes --]

Hi

56d9ca69d7f229dccee6ad47c67a37f558196fb7 introduces a "use after free"

with a srt file as input like this:
1
00:00:00,000 --> 00:00:01,000
Test

valgrind ./ffmpeg_g  -i test.srt  -f hls t.m3u8

you get this in about 50% of the runs

I noticed this issue when debuging the format string issue submited by Sarthak Munshi

==3961210== Thread 2:
==3961210== Invalid read of size 1
==3961210==    at 0x4853DF0: __memcpy_chk (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3961210==    by 0x324297: enc_open (in ffmpeg/ffmpeg_g)
==3961210==    by 0x325F59: encoder_thread (in ffmpeg/ffmpeg_g)
==3961210==    by 0x33E9AF: task_wrapper (in ffmpeg/ffmpeg_g)
==3961210==    by 0x740BAA3: start_thread (pthread_create.c:447)
==3961210==    by 0x7498A63: clone (clone.S:100)
==3961210==  Address 0xca93ac4 is 580 bytes inside a block of size 582 free'd
==3961210==    at 0x484988F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3961210==    by 0x29824A: ff_codec_close (in ffmpeg/ffmpeg_g)
==3961210==    by 0xD101FC: avcodec_free_context (in ffmpeg/ffmpeg_g)
==3961210==    by 0x31C768: decoder_thread (in ffmpeg/ffmpeg_g)
==3961210==    by 0x33E9AF: task_wrapper (in ffmpeg/ffmpeg_g)
==3961210==    by 0x740BAA3: start_thread (pthread_create.c:447)
==3961210==    by 0x7498A63: clone (clone.S:100)
==3961210==  Block was alloc'd at
==3961210==    at 0x484E366: posix_memalign (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3961210==    by 0x1871164: av_malloc (in ffmpeg/ffmpeg_g)
==3961210==    by 0x184E70A: av_asprintf (in ffmpeg/ffmpeg_g)
==3961210==    by 0x1301482: ff_ass_subtitle_header_full (in ffmpeg/ffmpeg_g)
==3961210==    by 0x13014FA: ff_ass_subtitle_header (in ffmpeg/ffmpeg_g)
==3961210==    by 0x130152B: ff_ass_subtitle_header_default (in ffmpeg/ffmpeg_g)
==3961210==    by 0x9464B6: avcodec_open2 (in ffmpeg/ffmpeg_g)
==3961210==    by 0x31B996: dec_open (in ffmpeg/ffmpeg_g)
==3961210==    by 0x31E23F: dec_init (in ffmpeg/ffmpeg_g)
==3961210==    by 0x3212D5: ist_use (in ffmpeg/ffmpeg_g)
==3961210==    by 0x331FAC: ost_add (in ffmpeg/ffmpeg_g)
==3961210==    by 0x333E40: map_auto_subtitle (in ffmpeg/ffmpeg_g)
==3961210==
==3961210== Invalid read of size 1
==3961210==    at 0x4853DFD: __memcpy_chk (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3961210==    by 0x324297: enc_open (in ffmpeg/ffmpeg_g)
==3961210==    by 0x325F59: encoder_thread (in ffmpeg/ffmpeg_g)
==3961210==    by 0x33E9AF: task_wrapper (in ffmpeg/ffmpeg_g)
==3961210==    by 0x740BAA3: start_thread (pthread_create.c:447)
==3961210==    by 0x7498A63: clone (clone.S:100)
==3961210==  Address 0xca93ac2 is 578 bytes inside a block of size 582 free'd
==3961210==    at 0x484988F: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3961210==    by 0x29824A: ff_codec_close (in ffmpeg/ffmpeg_g)
==3961210==    by 0xD101FC: avcodec_free_context (in ffmpeg/ffmpeg_g)
==3961210==    by 0x31C768: decoder_thread (in ffmpeg/ffmpeg_g)
==3961210==    by 0x33E9AF: task_wrapper (in ffmpeg/ffmpeg_g)
==3961210==    by 0x740BAA3: start_thread (pthread_create.c:447)
==3961210==    by 0x7498A63: clone (clone.S:100)
==3961210==  Block was alloc'd at
==3961210==    at 0x484E366: posix_memalign (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3961210==    by 0x1871164: av_malloc (in ffmpeg/ffmpeg_g)
==3961210==    by 0x184E70A: av_asprintf (in ffmpeg/ffmpeg_g)
==3961210==    by 0x1301482: ff_ass_subtitle_header_full (in ffmpeg/ffmpeg_g)
==3961210==    by 0x13014FA: ff_ass_subtitle_header (in ffmpeg/ffmpeg_g)
==3961210==    by 0x130152B: ff_ass_subtitle_header_default (in ffmpeg/ffmpeg_g)
==3961210==    by 0x9464B6: avcodec_open2 (in ffmpeg/ffmpeg_g)
==3961210==    by 0x31B996: dec_open (in ffmpeg/ffmpeg_g)
==3961210==    by 0x31E23F: dec_init (in ffmpeg/ffmpeg_g)
==3961210==    by 0x3212D5: ist_use (in ffmpeg/ffmpeg_g)
==3961210==    by 0x331FAC: ost_add (in ffmpeg/ffmpeg_g)
==3961210==    by 0x333E40: map_auto_subtitle (in ffmpeg/ffmpeg_g)



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

       reply	other threads:[~2026-01-30 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250930112036.4AD8768EDAD@ffbox0-bg.ffmpeg.org>
2026-01-30 15:45 ` Michael Niedermayer via ffmpeg-devel [this message]
2026-01-30 16:02   ` Michael Niedermayer via ffmpeg-devel
2026-01-30 16:05     ` James Almer via ffmpeg-devel
2026-01-30 16:10       ` James Almer via ffmpeg-devel
2026-02-01  1:11         ` Michael Niedermayer via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXzSDNOVks6yhdVW@neo \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=ffmpeg@haasn.xyz \
    --cc=michael@niedermayer.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git