From: Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marton Balint <code@ffmpeg.org>, Nicolas George <george@nsup.org>
Subject: [FFmpeg-devel] Re: [PR] Revert "lavfi: make sure frame SAR matches the link value" (PR #21482)
Date: Fri, 16 Jan 2026 11:48:53 +0100
Message-ID: <aWoXlYuOYW_ft9DI@phare.normalesup.org> (raw)
In-Reply-To: <176852016504.25.1615190366179230382@4457048688e7>
Marton Balint via ffmpeg-devel (HE12026-01-15):
> PR #21482 opened by Marton Balint (cus)
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21482
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21482.patch
>
> This reverts commit fcc33ada47e594d6b35b71c4a998af796f56492e.
>
> It breaks playback of files with changing aspect ratio in ffplay, such as [1], because the filter chain is initialized with the initial aspect ratio, so any change is overwritten.
>
> Michael already reported this issue at the time of patch submission [2], but it was applied anyway.
>
> Ideally we could reinitialize the filter chain, but we never wanted to do that just for an aspect ratio change, because a filter chain reinitialization in the middle of playback / encoding can cause even worse issues. So I think it is better to just revert this.
Hi. Agree with all that. Thanks.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
prev parent reply other threads:[~2026-01-16 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 23:36 [FFmpeg-devel] " Marton Balint via ffmpeg-devel
2026-01-16 10:48 ` Nicolas George via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWoXlYuOYW_ft9DI@phare.normalesup.org \
--to=ffmpeg-devel@ffmpeg.org \
--cc=code@ffmpeg.org \
--cc=george@nsup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git