Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Michael Niedermayer <michael@niedermayer.cc>
Subject: [FFmpeg-devel] Re: [PATCH] libavfilter: mark comp_expr_str as const in LutContext
Date: Mon, 19 Jan 2026 02:51:26 +0100
Message-ID: <aW2OHmmzNbSaRe5y@neo> (raw)
In-Reply-To: <CA+ngR6w3crL7Dz8P1628pHhxu9ghVxd8+gskNh1fNfBDFm2kaA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1472 bytes --]

Hi Adeba

On Wed, Jan 14, 2026 at 03:17:15PM +0530, Adeba via ffmpeg-devel wrote:
> Hello,
> 
> This patch marks comp_expr_str in LutContext as const to improve code
> safety.
> 
> Thanks,
> Adeba Shahnaz

>  vf_lut.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ac8e5f6f1618b72ab39c74d98ec218365ec6224e  /var0001-PATCH-libavfilter-mark-comp_expr_str-as-const-in-Lut.patch
> From c8bcd080f602bab8cd4e399db528377010ea8197 Mon Sep 17 00:00:00 2001
> From: Adeeba Shahnaz <adeebashahnaz@Adeebas-MacBook-Pro.local>
> Date: Wed, 14 Jan 2026 15:15:23 +0530
> Subject: [PATCH] [PATCH] libavfilter: mark comp_expr_str as const in
>  LutContext
> 
> ---
>  libavfilter/vf_lut.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c
> index d15fb85c4e..3acb08780c 100644
> --- a/libavfilter/vf_lut.c
> +++ b/libavfilter/vf_lut.c
> @@ -64,7 +64,7 @@ enum var_name {
>  typedef struct LutContext {
>      const AVClass *class;
>      uint16_t lut[4][256 * 256];  ///< lookup table for each component
> -    char   *comp_expr_str[4];
> +    const  char  *comp_expr_str[4];
>      AVExpr *comp_expr[4];

why the number of spaces ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

For a strong democracy, genuine criticism is necessary, allegations benefit
noone, they just cause unnecessary conflicts. - Narendra Modi

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      reply	other threads:[~2026-01-19  1:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  9:47 [FFmpeg-devel] " Adeba via ffmpeg-devel
2026-01-19  1:51 ` Michael Niedermayer via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW2OHmmzNbSaRe5y@neo \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=michael@niedermayer.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git