From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A6B274DD6C for ; Mon, 5 Jan 2026 16:44:27 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'sp10gNTtoKRyKcSDslFQ2WTsMqiNe4zKrKy+zNLCHh4=', expected b'VfLpW1t1GBX6keDfn5PIZKtuIw+rddaZyBjIkXMjmuE=')) header.d=niedermayer.cc header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767631458; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=6/g7KMEEZ9zyw9nq77D8E/XG8CUAOsplvExatsrLVW8=; b=Nyv0623UXrfb4ZBd7QXndbif3xuEOBfqlty/tv0sYMYq1nsGUBqCZucl9Ji8pjA3afXoF DKYCNGMKwEDSYxdJ6pBhoIF+ioGCe8r+EoTeGkgn9sLmtyeB70hV6hSPRma+Ox8nIpIc5ce HJU8m61zkZntCoyUgFoAylu5o/8F7eGLQkLPNJshLA1g1RPP4uKOgly9klgr7eyc4iza7/T liUou5GU31/WIEgQK4azbF/eYV4keTxxvPfEu6X13LFZZx7ZXEjwlqC02/lPP9oNrJ1AZvq kjpv0aiw3TwuUhOGvqjhX72Uaim/aCQvQ3JP4UqZo0VpKxltFsgmJyeU5weQ== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EF4ED690D76; Mon, 5 Jan 2026 18:44:17 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767631442; b=oDFRyoHUFje7GRnT5HruycRyx+Jxnsf8zhspq8mfVluZads2HaGZw9xG/8D3+GHBWBKD0 4dLf/xPtIdPzMG6+kA8QvjlZxoZFtLh3IKyk9Dx04YTT12uDZ4mPC/+s2gjqhIh1TyfwE9q 4w5H85JDgEAghs0ER8rGNsYLxSk3i9nlKjX8BmUDJ0K6j0Ih1BMoDQQxdArNd87I+zHx5Pb xci2SOGOx1helitNcDRrd4Ou+L1FVeCi+tKWs92v6VAXlgiMf2kAdOZX7YD6nGL0BJcuLfv iN+0MHnN29fTs0PeMh4aeFTL1RHAAOzWYhk6hDOIlFhozhNammpQJNqBiF3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767631442; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=sp10gNTtoKRyKcSDslFQ2WTsMqiNe4zKrKy+zNLCHh4=; b=XseatuqxTo5gfhQAAoV4MIusEI9sa2KLneoEoUKQt5u1W9BuGo/AsRIN9gQ2Z9ZS9WS6y pLOxzuCJ/XRmPXApQUnXgBNRkngzFZh7GUX7kZAFfBLGIPlKoFFOSxJg2WRWPwrIPgZz19l xxaqzMtmpmKNYMxcUQjN2WFeIeapmRs8gV+4KQoYtW/kCkJwtxnE0hkZOPZbAVOCZorSG+0 ntE3BquBJXwNEyFQvalzHzjNplnVC6ipnFP+zLExJB5/b/wVSgIhiW94poQ1ZF5SvWeXv3v NpUoj3Qqyf15Hs2yTJ1epNu/YicHvixfsji0Z5fIwWg8W6idHlpRdNGzG36g== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none (Message is not ARC signed); dmarc=none Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id ACF386903BA for ; Mon, 5 Jan 2026 18:43:46 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id E5908443B5 for ; Mon, 5 Jan 2026 16:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1767631426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VfLpW1t1GBX6keDfn5PIZKtuIw+rddaZyBjIkXMjmuE=; b=V5Bje2IRqnAOCyXZdtveaBnWN13AtveIX6KmaDZn2OjsAq0g0ELFsY8PHmmz0G+EM/ZbDv mZ/nMqxqpcwXRPvro5h8HIov7o1iIQXN8oLhWh3tLbYtEqSUvSklE8apWaX+m/Mdjq8u9Z 7JSkumkVuC2Ss/0GHo5mfNKOw/PHzBswQjh9f34pxQKHRNWvGDZXFFc+DXHmGvVenQPUS1 OBE9vUr5qYv/1yBz6EI3BWa0fZxmamSp8GVi4UDTX6GoIC5O2Gj3qdQeWSzAoAASGUtEKL Gr2p5VuV/5zxhTmyxxkc/ZWsrN9SLwAi6Q6fJBhMPcFuv8Vcyh9frShz3UOjuQ== Date: Mon, 5 Jan 2026 17:43:45 +0100 To: FFmpeg development discussions and patches Message-ID: References: <20251231121122.475-1-vivek.kj@somaiya.edu> MIME-Version: 1.0 In-Reply-To: <20251231121122.475-1-vivek.kj@somaiya.edu> X-GND-Sasl: michael@niedermayer.cc X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeljeekudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeiiedrhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieeirdehtddphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhqihgupefgheeltdekgeegfeeuhedpmhhouggvpehsmhhtphhouhhtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Message-ID-Hash: B44H2JTRR635L4UJBOK4RNEUS6Q2OK7F X-Message-ID-Hash: B44H2JTRR635L4UJBOK4RNEUS6Q2OK7F X-MailFrom: SRS0=fJqU=7K=niedermayer.cc=michael@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avformat/mov: fix sidx timestamp handling, use PTS instead of DTS List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michael Niedermayer via ffmpeg-devel Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============9165711280419896202==" Archived-At: List-Archive: List-Post: --===============9165711280419896202== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kiSU3s8H791397r0" Content-Disposition: inline --kiSU3s8H791397r0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Vivek On Wed, Dec 31, 2025 at 05:41:22PM +0530, Vivek Jain via ffmpeg-devel wrote: > The 'sidx' earliest_presentation_time field is defined as PTS. Previously= , it was incorrectly assigned to DTS, which could cause sync issues. This c= ommit fixes the assignment to PTS as noted in the existing FIXME comment. > --- > libavformat/mov.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 009ddfec80..f651d0387b 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5892,9 +5892,9 @@ static int mov_read_trun(MOVContext *c, AVIOContext= *pb, MOVAtom atom) > } else if (has_sidx && !c->use_tfdt || fallback_sidx) { > // FIXME: sidx earliest_presentation_time is *PTS*, s.b. > // pts =3D frag_stream_info->sidx_pts; > - dts =3D frag_stream_info->sidx_pts; > + pts =3D frag_stream_info->sidx_pts; // <--- FIXED This taken as a whole is wrong. First step is explaining why there is a FIXME comment and outcommented code only after that is understood can this be fixed, but either way the fixme and fix cannot co-exist. Either its fixed or not also the last change to this line should be considered 0de3b1f3588e1fc9e292= 098902ac79d8dd9792bc > av_log(c->fc, AV_LOG_DEBUG, "found sidx time %"PRId64 > - ", using it for dts\n", frag_stream_info->sidx_p= ts); > + ", using it for pts\n", frag_stream_info->sidx_p= ts); // Update log message too if you like, but logically just changing to = pts is the key. > } else { This comment is not usefull thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What is money laundering? Its paying someone and not telling the government. --kiSU3s8H791397r0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaVvqPQAKCRBhHseHBAsP q6oFAKCAbCvj1qNW8LckworFTT7tBi0gdgCfUvkC9+dG1Rv2dgTMy7pXo3ZzI2Q= =NuuO -----END PGP SIGNATURE----- --kiSU3s8H791397r0-- --===============9165711280419896202== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============9165711280419896202==--