From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 35C32442E6 for ; Sun, 21 Dec 2025 03:09:28 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'wppxXOl/B36nhkc3tyEg5f8Z3DQur5lFmAh16C9gDOg=', expected b'sJoZEIx/auwFJBj1wdrtI9WZd82gT4JCz69d1dIsewM=')) header.d=niedermayer.cc header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766286517; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=yaOSqFlPkVGOjEnzd0ZqdP3XSmBaZjq7o9ZELl3Eaus=; b=frEWA5HonpoJh47xlHSwpiT04z9e+n5RxuvFK1REl3AjOWDQOLKqMprMjq16wq/R4E01a gHi4h2FyBhv2N08dsRoMEUJedYeZXjQ5P2THkHz+26bsYtbf6OqZqh7mYRgN9nC5PPKrK0h Cf4GHQoiwiQBb2xQv8HyHoDoLdi5w2jMp25YWYHns5Cqxp73v7Csz5fjfst4W9+wdIH8yMr F/c9FFsKHq2LGOyLLjUXXMr9BO+O7HxDJDesztMWcVyNSAu4fq9oboAEEDntgs4Wgdp9X35 kqNRrEKLc0BtDUrgkn7Prjj+M1CboNp2qYjBjNlX5UW3f+8htGneSjIkkM9A== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1BED6690A29; Sun, 21 Dec 2025 05:08:37 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1766286503; b=OSZmrGVmPH1U7tViCly3kMmKT9tSB6G2c8OqegGq5N0D9BreV2VZgjqVEsiOqsvcwlY9R fE1PWBOMQkOPlAbTN+Hc+tgNK/407XC+tuIR9CH75s1i8Qz6sB2LWE/2PwOsCnJ3jReuHYu T2E6uR6FPkCrk54jNWigRKMleSSVwL7SnZhEWCicu0Hs2K282otHv9qtCUpD2uzjk4EbYx4 L8b3MAHX8zJ2g3OuVg0wJBc95qJ2Lx4GrOI7dznc4ZBTvUbmkG4KdkmJb4qXDhj+dSFmBt0 pwoHuDoWiUfapLmEzqVW0rJm/kIv+FZSEoBmMdsCaQN82GCMpaxiihQGvm1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1766286503; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=wppxXOl/B36nhkc3tyEg5f8Z3DQur5lFmAh16C9gDOg=; b=cSyrC59g/MW9aNXzmxOOg3lrMi+QgvwjOTBGTFjYEEruY/1fnOuiAg3Se6bE2HWvvS0nR KqQ/0TlC02SATIDJbhLhyrAroRxkOBuspypX+77wlIKRiAPdcPVVr0z9fvVAhchTdRkpjQz VIkjxFW6NnqN0vIYcN/dhoFp0tMjQd02CRyY8OmAiQPxlElj5CRI3QHHxsobAe61RSt8SN1 q3dzO2NqZjSQov9msGR4dJboilGRSrton4Ape4Ot/NfzSELyB1au5L+B/d+nX3U3sKkxOaw ccVeQ8UgjORtrNM+CDhoLYF67J2f9SH9OfEXyWjstfMcRnpJVPdL8lGhxRcA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none (Message is not ARC signed); dmarc=none Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6E0B668FED1 for ; Sun, 21 Dec 2025 05:08:06 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id A84B842D83 for ; Sun, 21 Dec 2025 03:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1766286485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sJoZEIx/auwFJBj1wdrtI9WZd82gT4JCz69d1dIsewM=; b=F4wo+OBo3JjK7ijyV/UZG2OFMR487kJOS92YRUoLtpMtciyH0iBkeS0xRjysVJdxU2jTfl DKkeyB68T7Nar60xmHz9pFbehA9nEX4kSb/PwRNsRR3xOx2c1hK3XqqRU9DTDC6mukOycw 49QJxJckWGgLJURJSOWEbnHaoqhYwSSPL7sGWPGoJiJ7JnyIQhvIdrZZnXmYH+5mKi/sAu TdIJuEhssMxcfK3c0EQFq26gPn0QWMsMSXEweQrX7UBSov/Qb+RPyau1JvtE7cXyLzDK8Q ycsON0tRiVtJblbO87VEgcXwIRfUCI/nsOHlVarAu4J8mEjGDt3lk4zYF/afMA== Date: Sun, 21 Dec 2025 04:08:04 +0100 To: FFmpeg development discussions and patches Message-ID: References: <20251220212839.2451047-1-Jason@zx2c4.com> MIME-Version: 1.0 In-Reply-To: <20251220212839.2451047-1-Jason@zx2c4.com> X-GND-Sasl: michael@niedermayer.cc X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdehvdelgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeiiedrhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieeirdehtddphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhqihgupeetkeegueekgedvffekfedpmhhouggvpehsmhhtphhouhhtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Message-ID-Hash: LUBBDAZGZTPN7PFDJNDNIISWLZ64HVTH X-Message-ID-Hash: LUBBDAZGZTPN7PFDJNDNIISWLZ64HVTH X-MailFrom: SRS0=Naky=63=niedermayer.cc=michael@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avformat/wavenc: use RF64 when needed List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michael Niedermayer via ffmpeg-devel Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============8064796588876415825==" Archived-At: List-Archive: List-Post: --===============8064796588876415825== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ESYo8Z/CQZltda+b" Content-Disposition: inline --ESYo8Z/CQZltda+b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jason On Sat, Dec 20, 2025 at 10:28:39PM +0100, Jason A. Donenfeld via ffmpeg-dev= el wrote: > Currently if you encode a large wav, ffmpeg will hint after the fact > that the resultant file is corrupted, because traditional wav cannot > handle lengths greater than 32-bits. This isn't very useful; nobody > benefits from getting garbage files. >=20 > You can manually work around this by adding `-rf64 always`, which most > players have support for. Most people don't remember to do this until > after the fact when their file is corrupted, or they don't figure it out > at all and wind up using the w64 container instead. >=20 > And so that's what `-rf64 auto` is for. It uses the larger format when > needed, and if not, uses the traditional wav that is probably more > compatible. The result of using `-rf64 auto` is that you can add it to > every command line -- and should add it to every command line -- to get > either a normal small file, or a non-corrupt large file. >=20 > This is a very sensible default to have on, rather than just producing > corrupt files and having users scrambling for solutions, and then having > to do a potentially expensive reencode after. With `-rf64 auto` on by > default, the user always gets a readable good file. And for users who > sometimes want corrupt files, there still exists `-rf64 never` that can > be enabled. > --- > libavformat/wavenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c > index a515f4e2a2..835a2157bc 100644 > --- a/libavformat/wavenc.c > +++ b/libavformat/wavenc.c > @@ -487,7 +487,7 @@ static const AVOption options[] =3D { > { "off", "Do not write peak chunk.", 0, = AV_OPT_TYPE_CONST, { .i64 =3D PEAK_OFF }, 0, 0, ENC, .unit =3D "p= eak" }, > { "on", "Append peak chunk after wav data.", 0, = AV_OPT_TYPE_CONST, { .i64 =3D PEAK_ON }, 0, 0, ENC, .unit =3D "p= eak" }, > { "only", "Write only peak chunk, omit wav data.", 0, = AV_OPT_TYPE_CONST, { .i64 =3D PEAK_ONLY }, 0, 0, ENC, .unit =3D "p= eak" }, > - { "rf64", "Use RF64 header rather than RIFF for large files.",= OFFSET(rf64), AV_OPT_TYPE_INT, { .i64 =3D RF64_NEVER },-1, 1, ENC, .= unit =3D "rf64" }, > + { "rf64", "Use RF64 header rather than RIFF for large files.",= OFFSET(rf64), AV_OPT_TYPE_INT, { .i64 =3D RF64_AUTO },-1, 1, ENC, .u= nit =3D "rf64" }, > { "auto", "Write RF64 header if file grows large enough.", = 0, AV_OPT_TYPE_CONST, { .i64 =3D RF64_AUTO }, 0, 0, ENC, .= unit =3D "rf64" }, > { "always", "Always write RF64 header regardless of file size.",= 0, AV_OPT_TYPE_CONST, { .i64 =3D RF64_ALWAYS }, 0, 0, ENC, .= unit =3D "rf64" }, > { "never", "Never write RF64 header regardless of file size.", = 0, AV_OPT_TYPE_CONST, { .i64 =3D RF64_NEVER }, 0, 0, ENC, .= unit =3D "rf64" }, breaks fate: --- - 2025-12-21 04:04:18.901071242 +0100 +++ tests/data/fate/filter-channelmap-one-str 2025-12-21 04:04:18.898363748= +0100 @@ -1 +1 @@ -e18791f65ce5861e130b2c3e472ab90a +8f8a664b694f18e1e9ae1b9ccfa6f30c Test filter-channelmap-one-str failed. Look at tests/data/fate/filter-chann= elmap-one-str.err for details. make: *** [tests/Makefile:323: fate-filter-channelmap-one-str] Error 1 if this change is intended, then update the fate tests and explain in the c= ommit message why they change thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew .= =2E." --ESYo8Z/CQZltda+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaUdkkQAKCRBhHseHBAsP qzFsAKCDCdJ/24CiyAnQSXnyJ273cR1LIACbBfwGXjd6Wn1eWWLJSAU+60R240Y= =uvZF -----END PGP SIGNATURE----- --ESYo8Z/CQZltda+b-- --===============8064796588876415825== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============8064796588876415825==--