[FFmpeg-devel] Re: [PATCH] avutil/opt: support DOS paths in key value parser (PR #21008)

[Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Kacper Michajłow via ffmpeg-devel (HE12025-11-24):
> PR #21008 opened by Kacper Michajłow (kasper93)
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21008
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21008.patch
> 
> This allow to pass DOS path in filter graph string. Although we use `:`
> as separator, we can make an exception for DOS path looking string. In
> which cases first `:` is allowed to be included in the value.
> 
> Fixes drawvg filter, which would otherwise fail to parse `file` option
> when DOS path is provided.
> 

I am strongly against this, it makes the parsing erratic and requires
weird special cases in code that generate options strings.

Let users escape their paths.

> Fixes: fate-filter-drawvg-video

If the problematic paths come from FATE, then fix FATE to escape paths.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org