[FFmpeg-devel] Re: [FFmpeg-cvslog] [ffmpeg] branch master updated. 92f2f9ea5c avcodec/d3d12va_encode: D3D12 AV1 encoding support

[Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1783 bytes --]

Hi Nicolas

On Tue, Dec 02, 2025 at 01:07:08PM +0100, Nicolas George via ffmpeg-devel wrote:
> Michael Niedermayer via ffmpeg-devel (HE12025-12-02):
> > > +    assert((total_size + tile_group_extra_size) * 8 == bit_len);
> > this possibly should be av_assert*
> 
> Without a doubt.
> 
> Michael Niedermayer via ffmpeg-devel (HE12025-12-02):
> > this patch breaks decoding a video with a single image:
> > 
> > this works and creates our single image video
> > ./ffmpeg -i lena.pnm /tmp/file.m2v
> > 
> > this fails after the patch:
> > ./ffmpeg -i /tmp/file.m2v /tmp/file.jpg -y
> 
> This is bad.
> 

> Can we acknowledge that we observe a worsening in the scrutiny that
> patches receive before being pushed?

This would require some statistics work, to be sure

In this specific case i simply didnt test it quick enough, i have a script
that warns me of new assert() so i should notice eventually.


> 
> Also, right now: make a pull request with a trivial patch, a
> controversial one and another trivial patch, wait a few days, push:
> nobody will notice because the PR will be named after the first,
> trivial, patch, and the push notification will be named after the last,
> trivial patch.

These are several seperate issues.

First, forgejo simply doesnt send the right details to ffmpeg-devel.

Second, our current "cvslog" reporting code is pure shit, i suggested previously to
switch this. nothing happened, ok, ill switch it, will try it with ffmpeg-web first

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org