From: Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Wenjie Yin <wenjyin@qti.qualcomm.com>,
"wangao.wang@oss.qualcomm.com" <wangao.wang@oss.qualcomm.com>,
"Qiwei Liu (QUIC)" <quic_qiweil@quicinc.com>,
"renjiang.han@oss.qualcomm.com" <renjiang.han@oss.qualcomm.com>,
Michael Niedermayer <michael@niedermayer.cc>
Subject: [FFmpeg-devel] Re: [PATCH v2] libavcodec/v4l2_buffers: fixing buffer alignment issue
Date: Mon, 1 Dec 2025 03:16:20 +0100
Message-ID: <aSz6dJW3OWZWyCFd@neo> (raw)
In-Reply-To: <DS4PR02MB1084220D110898B497D5B4E1F9AD1A@DS4PR02MB10842.namprd02.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
Hi Wenjie Yin
On Tue, Nov 25, 2025 at 09:59:00AM +0000, Wenjie Yin via ffmpeg-devel wrote:
> V4l2 drivers may return buffer width & height with aligned values, which
> may be different from frame width & height. Bytesperlines and strides
> should be check for aligned buffers when copying pixel data. When width
> aligned, copy with planar; otherwise, copy line-by-line to dest buffer.
>
> Co-authored-by: Renjiang Han <renjiang.han@oss.qualcomm.com>
> Signed-off-by: Wenjie Yin <wenjyin@qti.qualcomm.com>
> ---
> libavcodec/v4l2_buffers.c | 97 +++++++++++++++++++++++++++++++++++----
> 1 file changed, 87 insertions(+), 10 deletions(-)
Doesnt apply: (the patch you posted a few minutes earlier applies cleanly though)
Applying: libavcodec/v4l2_buffers: fixing buffer alignment issue
Using index info to reconstruct a base tree...
error: patch failed: libavcodec/v4l2_buffers.c:359
error: libavcodec/v4l2_buffers.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 libavcodec/v4l2_buffers: fixing buffer alignment issue
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 163 bytes --]
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
prev parent reply other threads:[~2025-12-01 3:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 9:59 [FFmpeg-devel] " Wenjie Yin via ffmpeg-devel
2025-12-01 2:16 ` Michael Niedermayer via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSz6dJW3OWZWyCFd@neo \
--to=ffmpeg-devel@ffmpeg.org \
--cc=michael@niedermayer.cc \
--cc=quic_qiweil@quicinc.com \
--cc=renjiang.han@oss.qualcomm.com \
--cc=wangao.wang@oss.qualcomm.com \
--cc=wenjyin@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git