[FFmpeg-devel] Re: [PATCH] tcp: add TCP keepalive tuning options

[Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Practice2001 via ffmpeg-devel (HE12025-11-21):
> Addition of tcp_keepalive, tcp_keepidle, tcp_keepintvl, and tcp_keepcnt
> support to the TCP protocol. Exposeing these options to the HTTP protocol
> so they can be used for HTTP(S) connections. Updated documentation.
> Tested with: ./configure && make && make fate
> 
> Fixes ticket #11671.
> 
> Signed-off-by: Practice2001 <cordacct2001@gmail.com>
> ---
>  doc/protocols.texi | 26 ++++++++++++++-
>  libavformat/http.c | 36 +++++++++++++++++++++
>  libavformat/tcp.c  | 80 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 141 insertions(+), 1 deletion(-)

Hi.

Is there something new in this proposal that makes my comment of a few
days ago
<https://lists.ffmpeg.org/lore/ffmpeg-devel/aSCqAx-_6RFXR8Wq@phare.normalesup.org/>
obsolete?

If your goal is to fix broken connections that take forever to be
recognized as broken, you need to implement it as application logic, you
cannot rely on kernel parameters not meant for that, especially kernel
parameters that do not exist on some supported systems. At the very
least your solution needs to work on Windows.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org