[FFmpeg-devel] Re: [FFmpeg-cvslog] [ffmpeg] branch master updated. 92f2f9ea5c avcodec/d3d12va_encode: D3D12 AV1 encoding support

[Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Michael Niedermayer via ffmpeg-devel (HE12025-12-02):
> > +    assert((total_size + tile_group_extra_size) * 8 == bit_len);
> this possibly should be av_assert*

Without a doubt.

Michael Niedermayer via ffmpeg-devel (HE12025-12-02):
> this patch breaks decoding a video with a single image:
> 
> this works and creates our single image video
> ./ffmpeg -i lena.pnm /tmp/file.m2v
> 
> this fails after the patch:
> ./ffmpeg -i /tmp/file.m2v /tmp/file.jpg -y

This is bad.

Can we acknowledge that we observe a worsening in the scrutiny that
patches receive before being pushed?

Also, right now: make a pull request with a trivial patch, a
controversial one and another trivial patch, wait a few days, push:
nobody will notice because the PR will be named after the first,
trivial, patch, and the push notification will be named after the last,
trivial patch.

Regards,

-- 
  NicolasGeorge
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org