From: Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jack Lau <code@ffmpeg.org>, Nicolas George <george@nsup.org>
Subject: [FFmpeg-devel] Re: [PATCH] Revert " avfilter/avfilter: always forward request frame in filter_activate_default" (PR #20944)
Date: Tue, 18 Nov 2025 20:29:51 +0100
Message-ID: <aRzJL8tDAc9-JJ8G@phare.normalesup.org> (raw)
In-Reply-To: <176339557853.25.7196239267873298644@2cb04c0e5124>
Jack Lau via ffmpeg-devel (HE12025-11-17):
> PR #20944 opened by Jack Lau (JackLau)
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20944
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20944.patch
>
> Fix #20940
>
> This reverts commit 4440e499ba
>
> It breaks some filters like feedback, and make
> li->frame_blocked_in check invaild.
>
> Signed-off-by: Jack Lau <jacklau1222gm@gmail.com>
Yes, thanks.
I think the next one, “avfilter/avfilter: make filter_activate_default
request frames on behalf of sinks”, needs to be reverted too: it is a
mistake to expect a single logic to work for every kind of sinks.
Really, sinks have never worked reliably, they need to express their own
logic.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
prev parent reply other threads:[~2025-11-18 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 16:06 [FFmpeg-devel] " Jack Lau via ffmpeg-devel
2025-11-18 19:29 ` Nicolas George via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRzJL8tDAc9-JJ8G@phare.normalesup.org \
--to=ffmpeg-devel@ffmpeg.org \
--cc=code@ffmpeg.org \
--cc=george@nsup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git