From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5A8AF4D172 for ; Tue, 11 Nov 2025 15:28:32 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'Q4DMprjSPbq1ish6XkH+NAL4yNRs8uusWkYQLfQyPCc=', expected b'JjHMlz2K8UM3crIRi7Eg9yzWtoUFcpMOLlbLguryPk4=')) header.d=niedermayer.cc header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762874902; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=NPHYiWiIT0nq+9MZk0coA1RE9lVETNtURm8OYwyA/ck=; b=sXjV3Sq0GteHRJYW89gfr5I+IBU3gNrGZo0ul99IXohl56gc+IJey+dPpnHKpDWHAfdga WpgQLekY3yPEf/DqQuxYL2piT4x7r+4nkW/VuAoqo81Dd+0KirPnBzFoN2vlT5nX099N0S4 zOEBHXRnKR9YvN3ifbhUVaJTZNlA85pDgw5dwhLKX9roUICeKBT8M0tksTvrPndDiM6AInv /ICZfx4wvMpmffldXwpC+8wxN7YndYy51zBhgQX3lbQyGrW74igZNfcki8UKjiP2flEDePT po7ukw36o6Q/dlz/XgPBkOmw6nF/0yOVfCiQUB+jkkzB2BtNGbpOiVvlRiMA== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1603168FD05; Tue, 11 Nov 2025 17:28:22 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762874883; b=gb2Uw71DFnvkTBS6iQjEPKlx4tGUThKMPzT4lZWrXSJ/MZuzh6J6Ru5zQg6Q/e4/5ubA/ AD3NRGqnYJWvKmuJR0cAntNZd4IpvliDTNttwH2kyIUc66ac1BZBrEntY+CDFSlm/iu+6xz O9XVD+orrm/i3qQPNkaOv595OP3EHn3D8de9MWNjgfdi13EsEkUV7JncTBTKBJG6tPQ4cdJ Bne4GyL8J8qzAkd7V7e9RkenhdSGr+HOcIESvRDVIbbP1B73qW2b9WZ3dUQ5jVyHAgeGCPZ eMLLkO6SwFfkq8hv2ehHvRvaRbdGJHJ1Cx9nUHESWrgzKzFy/hX3pcrJswwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762874883; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Q4DMprjSPbq1ish6XkH+NAL4yNRs8uusWkYQLfQyPCc=; b=sCizFTMB4g8MuPPM0aIJFrK58bVBnMiQGi03F6WXUE2l8ZlxNT81D9TgcF6g5mRt2LTz8 oPnnC8VVjNU+klbtaw01xDOUKf4zDLNz1vUmmqFTaDMP7ndgpNrC3SCSwariUMt5V5kddM0 wRk4cidIsbpHHTNf728KXeqYh4gKgzMAIJm2WJ8ucpB+uk2FUs088DGzy68wofSQZcq/CPn V8bUTArE9O02kOol7VcWhWjIBjxbf0NXWzppefRqQ+yI79Lbd4rv5pNr05c/oHcplPOGTL+ wlx4aM7YW6wWF5RnPL07AQd5N+2QTVJ2l0hCi4BZK/y1/0xHspRWmSVMvTiQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none (Message is not ARC signed); dmarc=none Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6CA9868FC4F for ; Tue, 11 Nov 2025 17:27:51 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 91629441D4 for ; Tue, 11 Nov 2025 15:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1762874870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JjHMlz2K8UM3crIRi7Eg9yzWtoUFcpMOLlbLguryPk4=; b=YD01tt1aU2f9OjXKH/X6EbA4nWEuFIr9CSOFAuuxkU4lGVzgS0xzhytx3bqqrsGIRevNnX x4TZzAMOrt3Ex5nVhMV7lxHaQL5qqApp5NtNr2gBTJLKFZ93tEJvsaLaxIsVHK+czLcnKB HHt5PKfWXK5vmjEw1/MNwxBd6mZmAHASktH0OvAEv8Bji089GK8TrKspyEs2jAMCn+akms yUm6csUbhNDB+q0q3a3k29Bu+iOeVqZREfPCdFyuCOYVTvU+wCMz/hcCqAmfQOnul5ukwa KJdSiDejz8E85yPnG0aAJb+zE73JhuVwKAp74oyzQpMruhuPrE78zbkNAVrT5Q== Date: Tue, 11 Nov 2025 16:27:49 +0100 To: FFmpeg development discussions and patches Message-ID: References: <20251105112952.1474387-2-mail@mathias.im> MIME-Version: 1.0 In-Reply-To: <20251105112952.1474387-2-mail@mathias.im> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdduheehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpedtledufffgieefvdekuefhudfgkeffffejveejgeejleeikeduvdeigeetheejieenucffohhmrghinhepughjihdrtghomhenucfkphepgedurdeiiedrieeirdehtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeiiedrhedtpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Message-ID-Hash: HPTLUCIYWL7UMZAV2KZ5IMZRJUD6GAED X-Message-ID-Hash: HPTLUCIYWL7UMZAV2KZ5IMZRJUD6GAED X-MailFrom: SRS0=X2QP=5T=niedermayer.cc=michael@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avcodec/tiff: Check order only for tags that we process List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michael Niedermayer via ffmpeg-devel Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============5453476540244514155==" Archived-At: List-Archive: List-Post: --===============5453476540244514155== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wqxPcIhHr+rK1UTN" Content-Disposition: inline --wqxPcIhHr+rK1UTN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mathias On Wed, Nov 05, 2025 at 12:29:53PM +0100, Mathias Koehler via ffmpeg-devel = wrote: > The initial out of order check was introduced with commit > ad29f9e47cb avcodec/tiff: Restrict tag order based on specification >=20 > This changes the check to only check against tags the we process > since tags that we don't process shouldn't cause any bugs. >=20 > Example of CinemaDNG files with incorrect ordered tags > that causes problems: https://www.dji.com/de/inspire-3/samples > --- > libavcodec/tiff.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) what tags are that ? any "user" tags that can be more cleanly excluded ? I dont like this patch because its not really leading itself to a clean implementation when more exceptions appear I think its better to define in a clean, terse and general way the ordering our decoder can handle. Something that works with all tags not just ones we skip thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 2 "100% positive feedback" - "All either got their money back or didnt compla= in" "Best seller ever, very honest" - "Seller refunded buyer after failed scam" --wqxPcIhHr+rK1UTN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaRNV8QAKCRBhHseHBAsP q7XZAJ4suNld+mVMDYI941qVnyMKxvEeKwCcCVzQaA5x9zu1b04tS6UID8fU3mI= =LrZb -----END PGP SIGNATURE----- --wqxPcIhHr+rK1UTN-- --===============5453476540244514155== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============5453476540244514155==--