[FFmpeg-devel] Re: [PATCH] avcodec/tiff: Check order only for tags that we process

[Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1230 bytes --]

Hi Mathias

On Wed, Nov 05, 2025 at 12:29:53PM +0100, Mathias Koehler via ffmpeg-devel wrote:
> The initial out of order check was introduced with commit
> ad29f9e47cb avcodec/tiff: Restrict tag order based on specification
> 
> This changes the check to only check against tags the we process
> since tags that we don't process shouldn't cause any bugs.
> 
> Example of CinemaDNG files with incorrect ordered tags
> that causes problems: https://www.dji.com/de/inspire-3/samples
> ---
>  libavcodec/tiff.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

what tags are that ?
any "user" tags that can be more cleanly excluded ?

I dont like this patch because its not really leading itself to a
clean implementation when more exceptions appear

I think its better to define in a clean, terse and general way the ordering
our decoder can handle. Something that works with all tags not just ones we
skip

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org