From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B944D4D16F for ; Tue, 11 Nov 2025 02:34:18 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'FUwC+7lfWRkqzHkB4UHNnd3oa8YtnoiONmnkbAMHkEc=', expected b'oFgvkWNZw5Sv7ZygVQyroQJ3U54F6cClBm57J/mXxY0=')) header.d=niedermayer.cc header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762828449; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=AtQlUr/ogGrUDDTAiZR7AjomiURNwZi4fJK+uTwwwlA=; b=EW0e0MxgNaSfIVot8MU2J2JeJFs6qiZ9SilIQ9sGSS1EvEOdS5DWsRmZr9hcxWedfe9oB dSiKbV2t4+A7Lq026YAoH5AQD2jxssdA/ceSyIvsfGVGwH5HsBgRs0j9tJ1k+Knck7Ff33c 8THPq2FOSIJ4sPK8sZdaeyjoU4YVbqknG/dF9IXnfIUvK4kGJ+DNK8TWr6vOgBcB6OM2nwX 3P15KLWPYi9lk460yPm1REsJWy5nxrwItNWCxSEp+xSAd/d+Sodd/6rCiYaH1RS8Y996rj7 gX+XD/OMNr2E5oDKyTsv7vHwdc58fAw42DONCm9oCvuGkpYruyDCiDJXGFCg== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C851068FBFF; Tue, 11 Nov 2025 04:34:09 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762828433; b=CL7BDO1Mb8wHdQqTHj26j5UFNSd3OKf+aADdn1T2G4XNN3AKCrF5b+nHii/hG9WZWcp85 UQVgnEjocCpVsmRHzj+WCjTqXRJgmwsIq1gtXtBeOuM6wGU5SyknjbtnAIROmXdHbamo/c8 KLBlaBoYEZU/96raVySIWzqcvenR7PlOwORCIalolKAdN5piPAkw1mW6yx9qXM58AvXVSt4 Ppt3xJ+8IJE/9JH80UwK1ofmzDGnvD9vzz3yZimIwXzh2YiUFf+K7Jiuc9SYsC8x3trO3zb 19o51P0k828GhoRXK8wF9Eh+v/4twjOxWWjUjFl62wJXyaqMC+MdQnnzwiQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762828433; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=FUwC+7lfWRkqzHkB4UHNnd3oa8YtnoiONmnkbAMHkEc=; b=rSVvHD5yLXN2iVDsUSWwycGl+RAxkmbIo9pmdQUSRZbAptGZmcDEFpw77cmzBdss9fexg Q3cIAbR3kubESUcF7XLy1uO2pAl9rvGshJCczVKBplMcXHHlY1wK8dGYS3yHmpLK4QW6pCH 3SysYdCT55pBsuuLiwyUe9Qcaedf7RvL+13ByjTZ5p/e3499tME2Mv17nLirxfiMCMJUSUG yoDrKRxWPFjSp118ihdbbtsbytyJrRZwLY2JF4qXnuDChXUc8d/oA18YT9cPVd88efUempu AoQlVB3rhZLK3QFimq6AC89cH/e09k7eqvQnr4D4Oo/fm0XnExftxG8Mk+/Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none (Message is not ARC signed); dmarc=none Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4DB7068FBA1 for ; Tue, 11 Nov 2025 04:33:39 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5FEAA43B46; Tue, 11 Nov 2025 02:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1762828418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oFgvkWNZw5Sv7ZygVQyroQJ3U54F6cClBm57J/mXxY0=; b=a6ioNhX1vMmpnrlxR8lwlneVNefGL44/YSKxTPppDwCaNpKl33KEq3z+7fBQV0T1kUbrX+ LNUGX3x12ZHRM3b+gOGSjavKzVTWKVEpsPOD6HIxJ6NLPE35jgjhcB8wGzPAbKphfq/YeV dIT/aOFHrzklAwj6JMoWRbYay/A5P/b7+KQF+kUJZeKLFK8ARyC/AnGrlgg67gSv40SlUF rW8nSFOCeHenjui97IRVKmQD5oO+zDhQNd+i4JSmYIMaUGEWqZnWMbYNJfRVoyGsw82Ev7 TyQwFx1mIpsLT0TRgR/VRGgWVmmTdE/QU428rG0B5v2wrlybRfvYkijmPhs4nw== Date: Tue, 11 Nov 2025 03:33:37 +0100 To: FFmpeg development discussions and patches , Niklas Haas Message-ID: References: <8bc32ae6-77aa-e5fe-bd1-cb55abdf9cc@carlh.net> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtddttddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeejhfelgefftdduveefudetkeetheeugedtkeeggffhleetgeeltefgieevgfelgeenucfkphepgedurdeiiedrieeirdehtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeiiedrhedtpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepvddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhgpdhrtghpthhtohepfhhfmhhpvghgsehhrggrshhnrdighiii X-GND-Sasl: michael@niedermayer.cc Message-ID-Hash: 3CXSZMWF7UTW6IORZVID3TQHCZZWB2YF X-Message-ID-Hash: 3CXSZMWF7UTW6IORZVID3TQHCZZWB2YF X-MailFrom: SRS0=X2QP=5T=niedermayer.cc=michael@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] libavfilter: Fix incorrect ebur128 peak calculation. List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michael Niedermayer via ffmpeg-devel Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============4507328346973326698==" Archived-At: List-Archive: List-Post: --===============4507328346973326698== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ImmehkJdsMp6Dy3" Content-Disposition: inline --5ImmehkJdsMp6Dy3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi adding niklas to the CC so its not missed but i agree the patch LGTM On Tue, Nov 04, 2025 at 08:52:36PM +0100, Nicolas George via ffmpeg-devel w= rote: > Carl Hetherington via ffmpeg-devel (HE12025-11-03): > > Since 3b26b782eeded9b9ab7fac013cd1a83a30d68206 it would only look at the > > first channel. > >=20 > > Signed-off-by: cth@carlh.net > > --- > > libavfilter/f_ebur128.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Hi. Thanks for the patch. I suspect the issue has been here for a longer > time, if only on one branch of the conditional build: >=20 > #if CONFIG_SWRESAMPLE > =E2=80=A6 > const double sample =3D fabs(swr_samples[i * nb_channels]= ); > #endif >=20 > versus >=20 > const double *restrict samples_ch =3D &samples[ch]; > =E2=80=A6 > const double sample =3D fabs(samples_ch[nb_channels * i]); >=20 > Anyway, the fix looks good to me. >=20 > Niklas, it has become mostly your code, what do you make of it? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out of college or go to community college in order to be able to afford settlements. -- The RIAA --5ImmehkJdsMp6Dy3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaRKgcgAKCRBhHseHBAsP q7CFAJ4ocW6l93n7N914g8XxwLmXvRx2dQCgmTlFg5NcijtiMUfCHZb+RxWlZx8= =urRV -----END PGP SIGNATURE----- --5ImmehkJdsMp6Dy3-- --===============4507328346973326698== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============4507328346973326698==--