From: Nicolas George via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Carl Hetherington <cth@carlh.net>, Nicolas George <george@nsup.org>
Subject: [FFmpeg-devel] Re: [PATCH] libavfilter: Fix incorrect ebur128 peak calculation.
Date: Tue, 4 Nov 2025 20:52:36 +0100
Message-ID: <aQpZhLD0EC3eDCSz@phare.normalesup.org> (raw)
In-Reply-To: <8bc32ae6-77aa-e5fe-bd1-cb55abdf9cc@carlh.net>
Carl Hetherington via ffmpeg-devel (HE12025-11-03):
> Since 3b26b782eeded9b9ab7fac013cd1a83a30d68206 it would only look at the
> first channel.
>
> Signed-off-by: cth@carlh.net
> ---
> libavfilter/f_ebur128.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi. Thanks for the patch. I suspect the issue has been here for a longer
time, if only on one branch of the conditional build:
#if CONFIG_SWRESAMPLE
…
const double sample = fabs(swr_samples[i * nb_channels]);
#endif
versus
const double *restrict samples_ch = &samples[ch];
…
const double sample = fabs(samples_ch[nb_channels * i]);
Anyway, the fix looks good to me.
Niklas, it has become mostly your code, what do you make of it?
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
next prev parent reply other threads:[~2025-11-04 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 20:38 [FFmpeg-devel] " Carl Hetherington via ffmpeg-devel
2025-11-04 19:52 ` Nicolas George via ffmpeg-devel [this message]
2025-11-04 21:34 ` [FFmpeg-devel] " Carl Hetherington via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQpZhLD0EC3eDCSz@phare.normalesup.org \
--to=ffmpeg-devel@ffmpeg.org \
--cc=cth@carlh.net \
--cc=george@nsup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git