From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8CF784D0D6 for ; Sat, 8 Nov 2025 22:42:46 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'5ZcdlPyQBjQUO2RCU9A4RyrZfHj5PQUH5MB5713TJMI=', expected b'6ykywf2olbAxDhIedYOjAg7yIMQDE+3C75vF0+4SOos=')) header.d=niedermayer.cc header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762641748; h=date : to : message-id : references : mime-version : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=G3+UpB3ck1/02Twi85GE0qtYek1CxQytSjXmB4mmyms=; b=plBW7IOgim6Y8c7cv1hnPW0bDnoW0nFkG7uEciAenIzDYb/cLFge1HUJ7szLaitTE6JXs jAmuoR6b5pVdS9m6XkrZSG0OJAvRvAUM0lXRgTWDYOUAUHhSAtTX/pUbyRvmgpggKsasDLY dZvDDtcl8InIUpYTIZkvdZSw3J7y4O33/qPRz93iIsFA22K7Uyh/ARCPQEhArRZZ2H9/NrU pTX4hLelyj5c9bPK8PXjFC/WFgrc7K+XyWUWIQGmzyzsHr6Mr5kPbDqs+OUNOaL2CxBrvTN ptzwExvp3jstXFaVdjsS8znQxbFmybQPzOIEa3NZegsLnMtp7qpvXCG2O//g== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id CF2C568F919; Sun, 9 Nov 2025 00:42:28 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762641724; b=mgwRMWsFAdE5iWuILgTuQfJRFU3sy5FzZr+rQ3Ri/jfPqpIsQYhlhU7baFc65qBuFTkWZ 7rv7qgy//LOGw2QgI1ZIJ47fzoPNhJWQHJWYnIwguzwCMZNSphwb2RAC2E/5iP4VSKDavCS ZsSFMFIIipPOEjNw7hu8m0a82JoDdrdkjrIAMPAHLQqzAbOv2A0hGsaedJhClau6ksQx91b R1cQGjYE7y+HaILpxA4csC2mQAZKbfwx6BjY6Yk0INMNy3zspjIgK2GqsHiCx62emwoqYWC yl1pnF1/tBOkXWOLMFDNgP0p0fabCz6q9t0uD40Xf/F0AS1OQ/7ofaImQwrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762641724; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=5ZcdlPyQBjQUO2RCU9A4RyrZfHj5PQUH5MB5713TJMI=; b=gqNYTGvlgbZXBN36gGoD7LfnCbeHrGqknqN8uwLH/wKQxslhwTIzB0e5GwFT8zj5pUoov O4KaiBX+0wy76bpm4lBuqU+mcebxGHn1dg9wttQ0hEPSmTOhl+pWBV7JdhtWOfwWC6jWUv1 8qBpfUq0JOn7G4pFNsddAMhxhraTJjftSj7FzJ4MMI6Rd5vPrpj62euFBjiXu7j11rDgaGK jEHOoB+dUrQ9jR8DQ/ws4WvzRE1tM+rVCX4lR31iMnqiKPt0DO1aeThgCB6+X1n24ENPks+ Ib9I7Tji3csSvgk0PP16ipAqsTSnHi+rxyf1qmADafLYW94JHLzhPtk6j7HQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=niedermayer.cc; arc=none (Message is not ARC signed); dmarc=none Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9509868E6B1 for ; Sun, 9 Nov 2025 00:41:49 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id D9E1541B5F for ; Sat, 8 Nov 2025 22:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1762641709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6ykywf2olbAxDhIedYOjAg7yIMQDE+3C75vF0+4SOos=; b=JLJ61e5WqS+EV9JxKBxl1liJfHlUTx7TRKIbxQDyycsZI9HPdIxhIroM01ZvK9ThpCSxk9 oOryjvqf6T6HWSoKizi9lGCP7HOsuYp+C25JvMIHnUB1JZRDWE/T4fDvVTBblXgezgmCnv U/3s7j04QA7v1bmKTO9bCU2BJqrsIDwMzxhi6tZauS/Q7qR9xNAiLhAXqBQ6mWfZMpgZzf 8bvRlAsyLQE+WU+eGZQjG+9TkF8pQmz5bemHyJs+btfbYOJ4PVXMXxZ+vwNj2qNf+X8oun i2fTdSuimjOpc7UgHTzsYq5r4x3NKeHVePk6GfNKKtKnpCo8BYcMeO1MKaGDAA== Date: Sat, 8 Nov 2025 23:41:48 +0100 To: FFmpeg development discussions and patches Message-ID: References: <20250713011030.1156550-1-michael@niedermayer.cc> <20250713011030.1156550-5-michael@niedermayer.cc> <20250714185852.GK29660@pb2> MIME-Version: 1.0 In-Reply-To: <20250714185852.GK29660@pb2> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduleefjeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeetgfegvdffieeuffevhfeitdfgfeejudekfeegteegveegjeegkedvveejleevkeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeeguddrieeirdeiiedrhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieeirdehtddphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Message-ID-Hash: C5NOO5ATS4GDAAHKRPVGKYTCL57HESXS X-Message-ID-Hash: C5NOO5ATS4GDAAHKRPVGKYTCL57HESXS X-MailFrom: SRS0=R6Rm=5Q=niedermayer.cc=michael@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH 5/5] avcodec/osq: Fix 32bit sample overflow List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michael Niedermayer via ffmpeg-devel Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============2592585091688472147==" Archived-At: List-Archive: List-Post: --===============2592585091688472147== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+FJm5ISX3mhnlwj2" Content-Disposition: inline --+FJm5ISX3mhnlwj2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 14, 2025 at 08:58:52PM +0200, Michael Niedermayer wrote: > On Sun, Jul 13, 2025 at 07:37:06PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: signed integer overflow: 2147483565 + 128 cannot be represente= d in type 'int' > > > Fixes: 428055715/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OS= Q_fuzzer-6358069900804096 > > >=20 > > > Found-by: continuous fuzzing process https://github.com/google/oss-fu= zz/tree/master/projects/ffmpeg > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/osq.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/libavcodec/osq.c b/libavcodec/osq.c > > > index 76090aa8d07..1d99ab32451 100644 > > > --- a/libavcodec/osq.c > > > +++ b/libavcodec/osq.c > > > @@ -390,7 +390,7 @@ static int osq_decode_block(AVCodecContext *avctx= , AVFrame *frame) > > > int32_t *src =3D s->decode_buffer[ch] + OFFSET; > > > =20 > > > for (int n =3D 0; n < nb_samples; n++) > > > - dst[n] =3D av_clip_uint8(src[n] + 0x80); > > > + dst[n] =3D av_clip_uint8(src[n] + 0x80ll); > > > } > > > break; > > > case AV_SAMPLE_FMT_S16P: > >=20 > > Why do you use a 64bit intermediate instead of simply using unsigned > > like we do everywhere else? >=20 > we can use an unsigned but the intend was to clip obviously > and while the C code uses 64bit the optimized asm should not > need that >=20 > Iam happy to change it to unsigned if you prefer no reply, will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates --+FJm5ISX3mhnlwj2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaQ/HJgAKCRBhHseHBAsP qxqPAKCZxcwXfLUDnR8oYK7S8TchwiqvgwCdGhxY/tcJ2KfcwHvkgySoHCGFjHs= =iD0d -----END PGP SIGNATURE----- --+FJm5ISX3mhnlwj2-- --===============2592585091688472147== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============2592585091688472147==--