Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Michael Niedermayer <michael@niedermayer.cc>
Subject: [FFmpeg-devel] Re: [PATCH] libavformat/asfdec_f: add asf video average framerate support
Date: Tue, 14 Oct 2025 01:15:07 +0200
Message-ID: <aO2H--ekwJohmNe1@neo> (raw)
In-Reply-To: <20251009112109.11309-1-zhangxu@sobey.com>


[-- Attachment #1.1: Type: text/plain, Size: 1755 bytes --]

Hi

On Thu, Oct 09, 2025 at 07:21:09PM +0800, ZhangXu via ffmpeg-devel wrote:
> From: zhangxu <zhangxu@sobey.com>
> 
> Refer to Advanced Systems Format (ASF) Specification
> 
> Parse AverageTimePerFrame from ExtendedStreamPropertiesObject
> 
> Signed-off-by: ZhangXu <zhangxu@sobey.com>
> ---
>  libavformat/asfdec_f.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

This breaks fate

--- ./tests/ref/fate/wmv3-drm-nodec	2025-09-24 19:09:24.202291445 +0200
+++ tests/data/fate/wmv3-drm-nodec	2025-10-14 01:10:51.797737754 +0200
@@ -10,55 +10,55 @@
 #codec_id 1: wmavoice
 #sample_rate 1: 22050
 #channel_layout_name 1: mono
-0,          0,          0,        0,      282, 0x000d949a
+0,          0,          0,       33,      282, 0x000d949a
 1,          0,          0,        0,     1088, 0x5cd379bb
 1,        435,        435,        0,     1088, 0x8dfa1368
 1,        740,        740,        0,     1088, 0xc0d211be
 1,       1023,       1023,        0,     1088, 0x8238113a
-0,       1208,       1208,        0,      137, 0x903c415e, F=0x0
-0,       1250,       1250,        0,      942, 0xd5b7d2aa, F=0x0
-0,       1291,       1291,        0,      841, 0xaffd8ce6, F=0x0
+0,       1208,       1208,       33,      137, 0x903c415e, F=0x0
+0,       1250,       1250,       33,      942, 0xd5b7d2aa, F=0x0
+0,       1291,       1291,       33,      841, 0xaffd8ce6, F=0x0
 1,       1306,       1306,        0,     1088, 0x9f8924b7


 Also the duration values seem not correct at all

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

  reply	other threads:[~2025-10-13 23:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 11:21 [FFmpeg-devel] " ZhangXu via ffmpeg-devel
2025-10-13 23:15 ` Michael Niedermayer via ffmpeg-devel [this message]
2025-10-14  4:26   ` [FFmpeg-devel] " via ffmpeg-devel
2025-10-23 11:21   ` via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aO2H--ekwJohmNe1@neo \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=michael@niedermayer.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git