Re: [FFmpeg-devel] Pushing without approval avfilter/vf_vignette: use AVFilterContext for logging

[Nicolas George <george@nsup.org>]

Niklas Haas (HE12025-08-12):
> As far as my understanding goes, only people with write access to the
> repository status have the ability to merge or approve PRs.

This is obviously wrong: write access to the repository is
all-or-nothing, expertise in parts of the code is not. This is why we
have maintainers.

With the recent clarification of who approved the series, we now know
that you had reliable but non-expert non-maitainer approval, which
should have let you wait a little less but not push immediately.

>								If you do not
> feel somebody can be trusted with write access, that is a separate issue
> irrelevant to this discussion.

Well, Michael has been giving these away like hotcakes recently, I can
think of two cases in recent months, but it is entirely unrelated to
this discussion.

> That aside, the person who reviewed the PR also has about 100x more activity
> than you

So what?

> Where in "MAINTAINERS" is this written?

An unfortunate oversight that will soon be rectified. But I believe it
should be common knowledge for somebody who has been in the project for
as long as you have, or for somebody who exchanged mails with me
recently on the very subject of libavfilter.

> Having a clearly defined process is a human solution to a human problem.

A bot is not a human solution.

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".