Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)
Date: Mon, 11 Aug 2025 10:40:08 +0200
Message-ID: <aJmsaI9MOj3UTUyF@phare.normalesup.org> (raw)
In-Reply-To: <20250811083754.1578368D1B5@ffbox0-bg.ffmpeg.org>

quink (HE12025-08-11):
> PR #20212 opened by quink
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch
> 
> A set of files begins with the following byte sequence.
> 
> 00000000  4c 41 4d 45 33 2e 31 30  30 aa aa aa aa aa aa aa  |LAME3.100.......|
> 00000010  aa aa aa aa aa aa aa aa  aa aa aa aa aa aa aa aa  |................|
> *
> 
> It seems they are encoded with lame, but missing header bytes at the
> beginning.
> 
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>

The commit message should explain better what the commit does.

What other software manages to recognize these files as valid?

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

       reply	other threads:[~2025-08-11  8:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250811083754.1578368D1B5@ffbox0-bg.ffmpeg.org>
2025-08-11  8:40 ` Nicolas George [this message]
2025-08-11  9:46   ` Zhao Zhili
2025-08-11  9:51     ` Nicolas George
2025-08-11 10:13       ` Zhao Zhili
2025-08-11 10:17         ` Nicolas George
2025-08-11 10:49           ` Zhao Zhili
2025-08-11 10:53             ` Nicolas George
     [not found] <20250811083755.CDB4D68BEE9@ffbox0-bg.ffmpeg.org>
2025-08-11 10:51 ` Michael Niedermayer
2025-08-11 12:04   ` Zhao Zhili
2025-08-11  8:37 quink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJmsaI9MOj3UTUyF@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git