From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 87F164CB54 for ; Fri, 8 Aug 2025 11:07:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4C11668CBB5; Fri, 8 Aug 2025 14:07:06 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id AC213687D79 for ; Fri, 8 Aug 2025 14:07:03 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 578B72GK017546 for ; Fri, 8 Aug 2025 13:07:03 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id C17B22EFE3; Fri, 8 Aug 2025 13:07:02 +0200 (CEST) Date: Fri, 8 Aug 2025 13:07:02 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20250808001741.23533-1-jiashengjiangcool@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250808001741.23533-1-jiashengjiangcool@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Fri, 08 Aug 2025 13:07:03 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] libavformat/whip: Add av_freep() to avoid potential memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jiasheng Jiang (HE12025-08-08): > I found that after the success of avio_alloc_context(), buffer is > assigned to rtp_ctx->pb->buffer and will be freed in whip_deinit(). > Therefore, I think moving av_freep() after end would cause a double > free. Indeed, you are right, I had not checked that. With your change, if somebody adds an extra operation that might fail between allocating the buffer and using it in the avio context. It might be better to free the buffer at the end and set it to NULL if avio_alloc_context() succeeds to avoid the double free, but that is very minor. So no objection to the patch, just take half a second considering my suggestion. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".