From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E7DC54CB84 for ; Fri, 8 Aug 2025 11:00:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 68CE568C2B6; Fri, 8 Aug 2025 14:00:17 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2C2C3687A7B for ; Fri, 8 Aug 2025 14:00:11 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 578B0AXp016223 for ; Fri, 8 Aug 2025 13:00:10 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 587292EFE3; Fri, 8 Aug 2025 13:00:10 +0200 (CEST) Date: Fri, 8 Aug 2025 13:00:10 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: <20250808023005.33565-1-jiashengjiangcool@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250808023005.33565-1-jiashengjiangcool@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Fri, 08 Aug 2025 13:00:10 +0200 (CEST) Subject: Re: [FFmpeg-devel] [PATCH] libswscale/tests/colorspace: Add av_free() to avoid potential memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Jiasheng Jiang (HE12025-08-08): > Add av_free() to avoid potential memory leak. This is main(), return means exit, no leak possible. This applies to most cases in tests, even not in main(): if something fails, the test will most likely exit with failure almost immediately, leaks are not an issue. Also: > Fixes: 3a74415d59 ("cosmetics, expand all tabs to four spaces.") This does not seem right. I do not know what is adding these comments, but its attribution logic seems a little simplistic. Just because=B9 the same lines were changes last in that patch does not mean that patch is what introduced the issue. It is quite obvious in that case with a cosmetic commit. Regards, -- = Nicolas George 1: Strange construction, but apparently idiomatic. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".