From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libswscale/tests/colorspace: Add av_free() to avoid potential memory leak
Date: Fri, 8 Aug 2025 13:00:10 +0200
Message-ID: <aJXYurMAJYGgxvR-@phare.normalesup.org> (raw)
In-Reply-To: <20250808023005.33565-1-jiashengjiangcool@gmail.com>
Jiasheng Jiang (HE12025-08-08):
> Add av_free() to avoid potential memory leak.
This is main(), return means exit, no leak possible.
This applies to most cases in tests, even not in main(): if something
fails, the test will most likely exit with failure almost immediately,
leaks are not an issue.
Also:
> Fixes: 3a74415d59 ("cosmetics, expand all tabs to four spaces.")
This does not seem right. I do not know what is adding these comments,
but its attribution logic seems a little simplistic. Just because¹ the
same lines were changes last in that patch does not mean that patch is
what introduced the issue. It is quite obvious in that case with a
cosmetic commit.
Regards,
--
Nicolas George
1: Strange construction, but apparently idiomatic.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-08-08 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 2:30 Jiasheng Jiang
2025-08-08 11:00 ` Nicolas George [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJXYurMAJYGgxvR-@phare.normalesup.org \
--to=george@nsup.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git