Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: add include for boolean literals (PR #20155)

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: add include for boolean literals (PR #20155)

[Nicolas George]

Leo Izen (HE12025-08-07):
> PR #20155 opened by Leo Izen (Traneptora)
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20155
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20155.patch
> 
> One call of av_assert2(false && foo) is in this file, which causes
> it to fail to compile on certain platforms with --assert-level=2. We
> fix this by #including stdbool.h to declare false as a literal.

Better replace the av_assert2() with av_unreachable().

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: add include for boolean literals (PR #20155)

[Leo Izen]

PR #20155 opened by Leo Izen (Traneptora)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20155
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20155.patch

One call of av_assert2(false && foo) is in this file, which causes
it to fail to compile on certain platforms with --assert-level=2. We
fix this by #including stdbool.h to declare false as a literal.

Signed-off-by: Leo Izen <leo.izen@gmail.com>


From dc700e03eacf5f1cb137ffb367eee12717c02a50 Mon Sep 17 00:00:00 2001
From: Leo Izen <leo.izen@gmail.com>
Date: Thu, 7 Aug 2025 08:14:02 -0400
Subject: [PATCH] avutil/hwcontext_vulkan: add include for boolean literals

One call of av_assert2(false && foo) is in this file, which causes
it to fail to compile on certain platforms with --assert-level=2. We
fix this by #including stdbool.h to declare false as a literal.

Signed-off-by: Leo Izen <leo.izen@gmail.com>
---
 libavutil/hwcontext_vulkan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
index 40e27d56ad..401b6fb4a7 100644
--- a/libavutil/hwcontext_vulkan.c
+++ b/libavutil/hwcontext_vulkan.c
@@ -30,6 +30,8 @@
 #include <unistd.h>
 #endif
 
+#include <stdbool.h>
+
 #include "thread.h"
 
 #include "config.h"
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".