* Re: [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154) [not found] <20250807101828.85FC768CF28@ffbox0-bg.ffmpeg.org> @ 2025-08-07 10:24 ` Nicolas George 2025-08-07 10:27 ` [FFmpeg-devel] Replies on the mailing-list (was: [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)) Nicolas George 0 siblings, 1 reply; 2+ messages in thread From: Nicolas George @ 2025-08-07 10:24 UTC (permalink / raw) To: Renjianguang-mi; +Cc: ffmpeg-devel Renjianguang-mi (HE12025-08-07): > PR #20154 opened by Renjianguang-mi > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch > > Functions and arrays in pixdesc will cause the code size to be larger (about 30KB or more). > For some products that only care about audio,you can use the audio_only switch to > reduce the size of pixdesc symbols. > You can enable optimization by using the command line --enable-audio-only > Signed-off-by: renjianguang <renjianguang@xiaomi.com> I do not like that it bloats the public headers and creates a binary-incompatible version of the library. And IIRC you cannot use CONFIG_SOMETHING in public headers anyway. Better leave the function as stubs in the libraries. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 2+ messages in thread
* [FFmpeg-devel] Replies on the mailing-list (was: [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)) 2025-08-07 10:24 ` [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154) Nicolas George @ 2025-08-07 10:27 ` Nicolas George 0 siblings, 0 replies; 2+ messages in thread From: Nicolas George @ 2025-08-07 10:27 UTC (permalink / raw) To: Renjianguang-mi; +Cc: ffmpeg-devel Nicolas George (HE12025-08-07): > > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154 > > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch > I do not like that it bloats the public headers and creates a > binary-incompatible version of the library. > > And IIRC you cannot use CONFIG_SOMETHING in public headers anyway. > > Better leave the function as stubs in the libraries. My comment did not reach the web monster, even though I overrode the reply-to header to include code@ffmpeg.org in the reply. Still a lot of details to fix to get this thing anywhere remotely usable. -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-07 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250807101828.85FC768CF28@ffbox0-bg.ffmpeg.org>
2025-08-07 10:24 ` [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154) Nicolas George
2025-08-07 10:27 ` [FFmpeg-devel] Replies on the mailing-list (was: [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)) Nicolas George
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git