Re: [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)

Re: [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)

[Nicolas George]

Renjianguang-mi (HE12025-08-07):
> PR #20154 opened by Renjianguang-mi
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch
> 
> Functions and arrays in pixdesc will cause the code size to be larger (about 30KB or more).
> For some products that only care about audio,you can use the audio_only switch to
> reduce the size of pixdesc symbols.
> You can enable optimization by using the command line --enable-audio-only
> Signed-off-by: renjianguang <renjianguang@xiaomi.com>

I do not like that it bloats the public headers and creates a
binary-incompatible version of the library.

And IIRC you cannot use CONFIG_SOMETHING in public headers anyway.

Better leave the function as stubs in the libraries.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Replies on the mailing-list (was: [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154))

[Nicolas George]

Nicolas George (HE12025-08-07):
> > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154
> > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch

> I do not like that it bloats the public headers and creates a
> binary-incompatible version of the library.
> 
> And IIRC you cannot use CONFIG_SOMETHING in public headers anyway.
> 
> Better leave the function as stubs in the libraries.

My comment did not reach the web monster, even though I overrode the
reply-to header to include code@ffmpeg.org in the reply.

Still a lot of details to fix to get this thing anywhere remotely
usable.

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".