From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 407184CA0F
	for <ffmpegdev@gitmailbox.com>; Thu,  7 Aug 2025 10:24:31 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5CDFA68CF11;
	Thu,  7 Aug 2025 13:24:27 +0300 (EEST)
Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E059B68CC09;
 Thu,  7 Aug 2025 13:24:15 +0300 (EEST)
X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org )
Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80])
 by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 577AOFSE008552
 ; Thu, 7 Aug 2025 12:24:15 +0200
Received: by phare.normalesup.org (Postfix, from userid 1001)
 id 292E22EFE3; Thu,  7 Aug 2025 12:24:15 +0200 (CEST)
Date: Thu, 7 Aug 2025 12:24:15 +0200
From: Nicolas George <george@nsup.org>
To: Renjianguang-mi <code@ffmpeg.org>
Message-ID: <aJR-zz3LaQ6qtXJd@phare.normalesup.org>
References: <20250807101828.85FC768CF28@ffbox0-bg.ffmpeg.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250807101828.85FC768CF28@ffbox0-bg.ffmpeg.org>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (nef.ens.fr [129.199.96.32]); Thu, 07 Aug 2025 12:24:15 +0200 (CEST)
Subject: Re: [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of
 symbols in pixdesc to optimize code size. (PR #20154)
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: ffmpeg-devel@ffmpeg.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aJR-zz3LaQ6qtXJd@phare.normalesup.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Renjianguang-mi (HE12025-08-07):
> PR #20154 opened by Renjianguang-mi
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch
> 
> Functions and arrays in pixdesc will cause the code size to be larger (about 30KB or more).
> For some products that only care about audio,you can use the audio_only switch to
> reduce the size of pixdesc symbols.
> You can enable optimization by using the command line --enable-audio-only
> Signed-off-by: renjianguang <renjianguang@xiaomi.com>

I do not like that it bloats the public headers and creates a
binary-incompatible version of the library.

And IIRC you cannot use CONFIG_SOMETHING in public headers anyway.

Better leave the function as stubs in the libraries.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".