From: Nicolas George <george@nsup.org>
To: Renjianguang-mi <code@ffmpeg.org>
Cc: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)
Date: Thu, 7 Aug 2025 12:24:15 +0200
Message-ID: <aJR-zz3LaQ6qtXJd@phare.normalesup.org> (raw)
In-Reply-To: <20250807101828.85FC768CF28@ffbox0-bg.ffmpeg.org>
Renjianguang-mi (HE12025-08-07):
> PR #20154 opened by Renjianguang-mi
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20154.patch
>
> Functions and arrays in pixdesc will cause the code size to be larger (about 30KB or more).
> For some products that only care about audio,you can use the audio_only switch to
> reduce the size of pixdesc symbols.
> You can enable optimization by using the command line --enable-audio-only
> Signed-off-by: renjianguang <renjianguang@xiaomi.com>
I do not like that it bloats the public headers and creates a
binary-incompatible version of the library.
And IIRC you cannot use CONFIG_SOMETHING in public headers anyway.
Better leave the function as stubs in the libraries.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2025-08-07 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250807101828.85FC768CF28@ffbox0-bg.ffmpeg.org>
2025-08-07 10:24 ` Nicolas George [this message]
2025-08-07 10:27 ` [FFmpeg-devel] Replies on the mailing-list (was: [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154)) Nicolas George
2025-08-07 10:18 [FFmpeg-devel] [PATCH] WIP: avutil/pixdesc: reduce the size of symbols in pixdesc to optimize code size. (PR #20154) Renjianguang-mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJR-zz3LaQ6qtXJd@phare.normalesup.org \
--to=george@nsup.org \
--cc=code@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git