From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id CA4E04C8FE
	for <ffmpegdev@gitmailbox.com>; Wed,  6 Aug 2025 14:56:54 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 359D468CB6D;
	Wed,  6 Aug 2025 17:56:50 +0300 (EEST)
Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40])
 by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9B41068B3B0
 for <ffmpeg-devel@ffmpeg.org>; Wed,  6 Aug 2025 17:56:43 +0300 (EEST)
X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org )
Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80])
 by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 576Eug5O002011
 ; Wed, 6 Aug 2025 16:56:43 +0200
Received: by phare.normalesup.org (Postfix, from userid 1001)
 id D91772EFE3; Wed,  6 Aug 2025 16:56:42 +0200 (CEST)
Date: Wed, 6 Aug 2025 16:56:42 +0200
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <aJNtKjnjlOfver7W@phare.normalesup.org>
References: <20250806145422.31198-1-jiashengjiangcool@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250806145422.31198-1-jiashengjiangcool@gmail.com>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (nef.ens.fr [129.199.96.32]); Wed, 06 Aug 2025 16:56:43 +0200 (CEST)
Subject: Re: [FFmpeg-devel] [PATCH v3] examples: Add check and replace
 av_free() to avoid potential memory errors
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/aJNtKjnjlOfver7W@phare.normalesup.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Jiasheng Jiang (HE12025-08-06):
> Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference.
> Moreover, replace redundant av_free() with fprintf().
> 
> Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
> Changelog:
> 
> v2 -> v3:
> 
> 1. Remove wrong Fixes tag.
> 
> v1 -> v2:
> 
> 1. Remove unnecessary goto.
> 2. Add fprintf() for error message.
> ---
>  doc/examples/decode_audio.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Still looks good to me, of course, thanks.

I do not maintain the docs.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".