[FFmpeg-devel] [PATCH v2] examples: Add check and replace av_free() to avoid potential memory errors

[FFmpeg-devel] [PATCH v2] examples: Add check and replace av_free() to avoid potential memory errors

[Jiasheng Jiang]

Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference.
Moreover, replace redundant av_free() with fprintf().

Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically")
Fixes: f5df897c4b ("examples/avcodec: split audio decoding into a separate example")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
Changelog:

v1 -> v2:

1. Remove unnecessary goto.
2. Add fprintf() for error message.
---
 doc/examples/decode_audio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c
index bcb3d87a69..26ce07a552 100644
--- a/doc/examples/decode_audio.c
+++ b/doc/examples/decode_audio.c
@@ -128,6 +128,10 @@ int main(int argc, char **argv)
     outfilename = argv[2];
 
     pkt = av_packet_alloc();
+    if (!pkt) {
+        fprintf(stderr, "Could not allocate AVPacket\n");
+        exit(1); /* or proper cleanup and returning */
+    }
 
     /* find the MPEG audio decoder */
     codec = avcodec_find_decoder(AV_CODEC_ID_MP2);
@@ -161,7 +165,7 @@ int main(int argc, char **argv)
     }
     outfile = fopen(outfilename, "wb");
     if (!outfile) {
-        av_free(c);
+        fprintf(stderr, "Could not open %s\n", outfilename);
         exit(1);
     }
 
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] examples: Add check and replace av_free() to avoid potential memory errors

[Nicolas George]

Jiasheng Jiang (HE12025-08-06):
> Add check for the return value of av_packet_alloc() to avoid potential NULL pointer dereference.
> Moreover, replace redundant av_free() with fprintf().
> 
> Fixes: 9a38184a14 ("examples/decode_audio: allocate the packet dynamically")

This one looks good to me, thanks.

> Fixes: f5df897c4b ("examples/avcodec: split audio decoding into a separate example")

???

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".