From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B347C4C872 for ; Wed, 6 Aug 2025 08:11:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6021368C7F8; Wed, 6 Aug 2025 11:11:55 +0300 (EEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BEF3A687D15 for ; Wed, 6 Aug 2025 11:11:53 +0300 (EEST) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from metallschleim.local ([91.62.6.9]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MKbkC-1v4WPc3lm8-00MPkN for ; Wed, 06 Aug 2025 10:11:52 +0200 Date: Wed, 6 Aug 2025 10:11:51 +0200 To: FFmpeg development discussions and patches Message-ID: References: <20250805185609.11596-1-jiashengjiangcool@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:gyPWClureBkdVWHa3uR+blMOXG2lSWa0UO5UlBVGJ1X0LVnwkYw rEV2h/UKB3AD/+DpkuZYHIQkEt8rnGQLEHqVGo3dLnR7+q2Eg0i0ls3wf4fEQWAd2yRkZ3Q 3PR1+Ka7O2u4DfyAd3z4TvnnNKbNG25ODF9OBKRJHm0wITS9Q7kYK0w5AQunJZAlmkJ0bPq zBeg7npaK5AoibG4MBRVw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+zME83SP+qE=;nz1JSOZ7N1CU2Lbe5CDK1v5uSMC jJ4OiWfa2yiX+j2Z6d0+CKacw6poRqRbnSCTPpzaVoOYpjCcSx0jZG9vk9+793R7aOuH3tLmM sapWgAetDPwsotyDM+/ZijUtOgoJ1zdovBvotmEF8zVUGJEpCEAk7eJZ7cOqCLD9uUOvZLD63 +7VkUepB232SODsnKeLkTNNFWNsMy8t6HNPkNnMi0AYoY+Z2iUL/m6p6vJoW74idKdjsHR6+3 TWbbAT8ZapgNRquC2XAyp6GLRoCLILTKXPoxlO2Ofzrr0jWxPe6NdzE3bARFFxTP4NCVRROZc aanEAcAXBxhobHBdw96vykrH8VMyF1W6odKPq1NqJd04N7cWFWCi0VCGNhWGHq0JjUUHpMZwc BM0Z2JsnLzx3xOsfIO5gQpjmaYw7LKVRL4nbCCE4CjodHdr/tJ3lDg8bTjj/uFEXTTDLI0q+k dG3lTUJbxFybyqar4C9Vw9yfREAigtrSOs5wXs9nd0Xz7DQBFE+uFWyRuU727DND+HCN7tm3C h168PDf2FJzmX59ZlfSBAKCaDJKh7qaWuTz4/vtSM7pHRXr06K8wXbNn/946s/E63QpGu/l4j QEn6X3A+mwxbTtr0Z5icDQVbf7WGSE2842Jga2MBHNnRThbzs+tkAfeBafqBE9f3YcaTQWH20 1FogdQLPMLTgF3C6bZ/s1O+Ea5vQOxMGQlmazs93PzmljdS5vXDj7UOkdsVISu0iPXHfJzRsP kVdUTLbFTVCl0LDRplIFNLpbqWxdeolh9jZM1SnIde7I+efm8uixXBsohCnL/+cZDFL9g47bX 8zVKNAIdsF0/ja7MgiI9MroNkpN+NssKGz1wrRbY0awwjYOxFaueShzaLQr2ZRy6kZZ7yKiF9 aA6HghSrKTr3IVt7zZg+bP9oQC24WC+Tyw35Zco/QQaioydn8bZB0WfiWJSsoFtR3DoNjYJP2 8wEq1eLl/Pr3aC0vA6k+lEdR8DqyfuqMMu9JDHhxqh5Gg9QGtpRerlcCFezi8bvxBG0KgqN1Q /PdEYDhiYUxPupj5tK3Xl9jg7NxASi3NWV6QnStetpmUSl4Xr2+TjS+e3OAF+ruca8TYlW7XA MYScKg1mn6ihhZtU0eNkza3vdB6RRT0uHG1hTB91MWfdth3pPcrBZrr0aMImi2cLRuN5R+YU6 VMTddCnSHbbCRv3TuWNCg9EfWM46Spe83wv+CvxQ8WaalsHrqqw1sySFXVV4lRWQt7v/peUSr zVHWWT3E7f3aY13WZAC8wvNk/5z1tB25CIcwuRJFcXjRlpx+mCTBwtzIGpxGXf+3RpEvL9Exa h4470omPRr+3x6KQpOOW2V8fY8LYcqKJ73NIwDBBh1zElOaiIw7S3hEu+r66uUyQqu2M2WSDB XPjxye8e3Nwa3jwM153cHw698TU865iGfaudmE8FF6kV3+vqMc1NEvlYDQmilLM7D8lhaicXh IZKS1yXYXYIqgh3hhA9s32p1Ac9wkxrjI7encavm0SO8IM4FKAmkFk1z+aNNVkZYEdXim9yuv 9RPG+B/z730SJcWLM1Xs5717NAr07FcSmg0tmy4yufX58B8NsZElL6HZ2L0uhsYR2UyVflTO7 89Befe5z/J4OJBNS2fmpKsPbNzT9b8+ysk08vNDlaVx5IzoYs8hk6JbQOuiFOcIVeecFVmBBW QfeMrgZJboYZu9uSnNomOriBXwIUxTOyTa6v2saK7DSZSAyLwoPL+n4JB4OFCwVdavpbd5ByG zv6WjIVemmCAIqw1fJrXcgNr07H3dbQHa5j/vvcbitponZJwGP5SCtgsndbaxOC6LiECW4OBt 2zYpeeDE2syE3CIBV4VcS6Wbbu6UaHkHfntL/75AYlPbbM7BYxO2TPdZRS5mLsG/y3V5RSlbq 0z9v2ijyEDei5QGKBLkATsxnsi2nCSKVE0yeidodW/NxsJo2j0gOkX+m2/4qS3YYAMmM+uGzU bwqJ2c43MQ59/EvgXcctJhwHN/CyP2Qa+w/YLG9aKA+iyau4i1JB0onf7jcljZRk92GZ4w28A AwlPrI2Kx8p/ho0VxyLUZNSCrblXNjqpAz1Om8xgpPbFuxlQ7QUtDa/+T2+mtVD4RxTk4otvB uLmrFFYlvxJ1xXZt3JJMH5igLulPuY+RpOg3YkMtjSy3m1m7rX5Zf4PA4DAYD14yvxvy3FvQP YE1zsPS+ynRWvzi4HpnoO4Le6KRnVF8F2fspIUrM9RBtYDPlU5Y/4VIJuO6qcMN1TPuTh1Adm r0yNOy/2m18HkKzsY+bSfVgzdRdTJdBTzsdX5/fFBHht+QnKQJi9Hz3BEIdibHV+0uIG9XBbD bHt/EsTHcVjkv7ExO/Rr+oE5QXAb1430OTQwzF8e4woKJ4y7m6v5pKMG3YnLjMi0tM8dTESM6 nxAgm/EwJZ2m3BlAGmChqS8m9lwaH4o5IvDbKK+n1gnosF+a+b6xD0tHp895aO0ofLJSsTsJ3 mr3oRhl/u/cPw0oDAWKP1+yQJDvufOBpBhNeS7chPQiDA9Aye2d/8n8jMnB5m52LvD8ZWXkP0 nAXWBH03BQbhXIbve0Uvoh4dUvwHx2t52zr0wZDWByFXP7bG4cXK3nCIrlpygeo4fpoA2qLTy xRiZ2ZloyKXtdAbBvLTFvTdYhb+E79QCAx+T93wTiQl7EYupTjPn825yVenNEAl1ds+T7fVU3 cO0+tJ76TeREUaDwiUDbRbHreT1Il3DHm1KaXqJBnaNZWDW+5dyldqT2aQSMnrlq1qhD+8i/c a3rMMn6EXOeQzLqjaawJxcIB79hlXlpeezAwuziSowmqTyHjV1hau6P2OcqdXjG6VRDAfohJe 9dUB9HKSR3SLqg6M6npxH9BFSbE3QclQb2TXB+2Y2R7HLqd2YvxPMYZVeEs1BCYMNJcik8j5Z C3OeWMupxwMkDpzMUch6/IxEIA4MarOqIH6QNx+c4+9sOMQJrkFiZHyDGTBDhWy6eqYlU6yvv X8WeGiiVz65y9P9AZ1HPbMN1/R/5MU0l3OwJEGp8hGxiAuPU1VtXSYy2+Bst4+zQ96ZqttgKX 0iIVBt1X9yh4Pg1UrrA7QWWs0SLmRIF8Hi5Xj2UWQgLDrLbN5QZfLst6Sym9V0OTbVicYtZ1j UfSYG4I7GeEyXH1E2L3UY0v9xJp/S2MZzB5cruJKV55MZScdiZkRNexkk9KhCRgFXZSUzsvxt x52KWlXO+Kyn3WD785STarpnz+aLCCk4x0MdIM4xN9yCWc+C98wdB5Uz28YNT3AIMEFrmSG+p 29V9FtwKwuz1XXXm+uj4VjN9/GSfx0hetn++VnUkRhaijpLrqQDk3OU3DjnYQa78vkbl8JV+l bAOIwi5IsR7WABOqbGlEGPEJs9ScpdtvqWjsjnBMa6QEG2JHn4OvKUHIkSbLFlaTgcSWXawx/ zCdanbke+XopgRUPeRZwB6ja9NZLZAWwVsrkaFSNaTs+CUX+TEwhI4nwIIgXxgehJ8JQjYXMV Lhx6jCD94sp59Gn921NWrYQ2HIIuCd9k= Subject: Re: [FFmpeg-devel] [PATCH] examples: Replace with proper error handling to avoid potential memory errors X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Strasser via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Alexander Strasser Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2025-08-05 22:18 +0200, Nicolas George wrote: > Jiasheng Jiang (HE12025-08-05): > > Moreover, replace with proper error handling to avoid potential memory leak. > > There is no potential memory leak with exit(). > > And it does not have to be a lesson in good C practices. I'm a bit undecided about this; especially because these are example files. Best would be to have them correct, small, and beautiful while still promoting good C practices. I agree that the patch as proposed is not an improvement over all. I would say it would be best to shorten it to only the first change: --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -128,41 +128,48 @@ int main(int argc, char **argv) outfilename = argv[2]; pkt = av_packet_alloc(); + if (!pkt) + exit(1); If someone wants to improve the example files to better handle errors and resource de-allocation for real world use cases, then it should be a follow up submission. Best regards, Alexander _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".