From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2F0974C6F5 for ; Mon, 4 Aug 2025 20:40:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7D80468C356; Mon, 4 Aug 2025 23:40:04 +0300 (EEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0E8FC688146 for ; Mon, 4 Aug 2025 23:39:57 +0300 (EEST) X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from metallschleim.local ([91.62.6.9]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1McpNy-1uAWAZ0K0o-00hoEj for ; Mon, 04 Aug 2025 22:39:57 +0200 Date: Mon, 4 Aug 2025 22:39:55 +0200 To: FFmpeg development discussions and patches Message-ID: References: <20250803074153.GK1079928@pb2> <20250803132600.GA29660@pb2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:uPVbGwLre3udLM1igadUyUHEJyr1AJpnVs30kjMahTAkFOTt2Gq ON91+lfMze29Zrd7tqTAGD3RhRZ6lkNdpHdxWmlCIyNK4yyTK71K229wpRc6fMcVL5a1zXD bgpK5D6LQP5YgxB9qatVC/ZRm0W4n3LmH1X/2WP/GsMZ82CoWaRaYBWGBwTfDCzM+7g7/FT AsDk1DA8vSBKdPx+zFEqQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tCd88yW14rA=;9d0ArbVnNkdET7hQUS/cHVpXJ07 JONoAsv2r5LMjyB5oq/lWjjiWBewk2lcPzQkINmykSohwkAQwNQ/1kxdf/a6NElFMS3Hk8W/K 7Twv6SUpCq4RNHChh0SCLr1vPoHTMV2xXheZ0ivC3hV3af6m1MafC9jqwmoP8Ci8OIDbiAa8/ 8ySi/yyq1jLNwjdYG37jHXiEV27I10m1cLIYBArWVqjkadsRJEl/qIwmJi8ioaO+05YGUS+Gm McHMRPLOvX6q/pqSyXut2N2nOxhCbZeZVna/WVLabvPi8r4tow1DgxQ2VfNoWPIj/+k2oSusc DqHRyrFXxsQ7/V0Fc9WmGGdGVNo4g2A6kDHpPwK48qNkFm8BcPF8ltQ8jLbldGqUM15thLJOr CnRsogJJL8b4Dic/ua7KYW9O/qbc/IXLBdUz5BiOGuWKehWm4UyLBtAioKur7u6vazPRIRdpp IKLAtwLHc73i+KI/37o57IkB6erCDZKDOeVlkYQZdESMcLzBstG2uFpUz5LPkEz/UXXHQ5cCH f/TlHUp5t9ZbbqQH1B0cFG45UqtILvj0fS1y5xvi1k6DpJyQrbakc/FCkcMJOCC5+Y3YTA5Nq 1d9QyIB9baLDXaFSkMVUgK9EIi31n1UyEcYciQBfGpwJBgabKhCIGzsuXBPVXnzzX846vosmo YAu2dx+CtoTGoo990DjSfKFV117ReciELzblmQ3renT+9kZbKGVwjrM8h4wDhbnuZjzMBCG60 MtKXiUASVZet+tqLWvWOJAviWE31UZAz8NnBR6xFw0CaNwy5JcVJ6kjYvETyeqUOeaM92C0qE gcZK+Si+YasgF1fUDZ+ipEPQ6onnFuxZRQr6ShtdKQEqDnHmt7bDdvKEGGCRUwp43PbA2jiaO rsY75nQubztlJutsCfZC5fb4ItM1QOobLGXOIwiYvrtQPme7s+FgJ9b1tu2j+tVj9LNZrfoGy RBlQcy9dmUWDrWPVSF6xH5Qv5yPQK93FqOdiNC9ACEszTYi5K8g69EiRvi9wXJZVobmUSlwwn IcHqaVySZxp/cgp2FlbWBEKqGhmLN1Tq2PPEG+iBGzHEIIXIr+TB6vLTu8qSZl7aCsVvijK9b E1NnjadSnaR47KmuKhQF4bPx+VdNlPnREbzQ8RaEa0QGYYQmAjNQJB3mVqWCII/oSJjEl8KFm K/xviQD2/qJXhWwbK7KmTVAIh/2F5bLFC5P9UZu5ahog3kM9EbkvuLaEQKkXrwPQJ2oGblGDA nIgjMP5/jg10zGfRvs9M1HAZG7xL8zAWEmmR2mV9r3MZDRg17NGgSRmiC7c+0pIrJuPKX6gE+ 5wb4tTLIKRghkyExcIgn1O8z+5sugyox3ZNTllY17eBkTnUtefAl3lfhkm2vO1zswSQQVsfWk 61Rw0fD60kSnOQYgJgTwNwJt5dNI9O+PksTEnQV2YOZEyU7sFRqkOxnrFWZV4Rexoe27oJ9rh NNWH/lHIEeqolovgcK3S19LSkhF7xtk9teWQG8FqOpPKwoiN8RM5dETM35pW5SVcwo0ioasHf 6XDFWuA5IqCS5s6oZo7jUmoLa/QZTzlcng/nvTGeDtQyWrDIgKIo9ukRLFgObL/bzXchUvNd+ 1glDFzNnQeM/MSe7KJvL7iQwyz78hWvacPqwfHmmqVlAnGRnG1ZiQ74cp+Zb523mMUr7odHzC tja6qrUq3GruO4EYZ0ijCg2jbugI0hQsKV252tz5cZBvaCuyUyBiqyzpLZTCnF4CAzh6zC05+ G6nSZfiLKvUYTz/RSgc2p7cYB35d1du9l+ATQrVg3aMgEREOY8bB4mp9/0bzZRw/jZnmm7B6j Y2comPW92OrEPWYD27RTdVzwaQSUQHqUXtmZob6T2V5rbx7Rj/bAZaiMg85nCskywA2xrvfDQ LaQ+gxSxie5jRUsAJWspL8Ot53bJKFXv3Zcoh/mwQ1Lf7cF25r5m+9IHnzMonDEXWMEIrqjaB uzsDsJ7Mod3HQY32kjjdOoUJT2xJU28zA1EHmLFZifhUclx0oy4Ds7zPlNy6GfYgtjZFYnDeb x0svseQFjZLbcW/qC4JhaChhidLNx7VyXd/SjB+40MkAy3AnNnWHGsIfZF1Yh9EdmA4by9ILW fNgm8CntCXkTVcbazQckGooeMHgs6tuU513stJY6gT4Hqob6go00VIdxTpPS4d+oxzhpdyOEI aIiJL9+Bud++9BW2GbsfOMSSSPgY39tdT/3tengrACh0k6tmFDObj7k9brUQRpTXoXMJZQ7Vv eyapa5JlY1C9MPw8wekPk+thBGMmlDMyi87kpvNjZrWGJJBIeZUgXX1RS1mWPm6NfeomzVo+2 zaGV0saayMONWAnF57Oney1WPNWZpLBPNfm1/3ckz8A5XMEKeK/HwkqPe784jV+f2MZN6O/d4 72Z/1ja3F2O+C9HMlIRwAtDTD6xTgkvOkr44yv1kmQO2RoGgEsZG6Z8fA/9U1b1HWCDSgZ994 pR9IgoNdqS6CJT6T2Fb1GvRDTrW4xWJbhmxvVxKWlENivXRBKoCVF20a99apacUxIdAKbzmtV 6ncxrqRX0UP5Y/FOV9m9+knRmZK/Fh2/hmBQKUETuKpjHHARlA4FzjOxrKgZYL7lHc4TZGlxB mzEO8qnVfVfQX4TkVtSNyyaTXhIxgEmr5RTB9KWUCtiC7rcXG0rf3kJp/b6O8qgbQOIrnBheI vfr+reGhtvaVZKOxe1+LNxLbD9bJb3KO8gQehry1+FtaEWeqkFOIlQgzBCKJFj7cuXLecjGNv ucIMm0NQURiULLcgMmPRsJSeXLPoxfpD9Hqn7TY4dP588jgDrt6UCPxGx86bIWGo3NauaQDPW l/lzYQslj22mEmo6C40lE7b+5sQzhQLvuiPSjLMkxH8eUWWIucht7TiIfFOjBo6VDyDmFvGVL bZf+CyOuT4QdJEIhPbIwOrj3WDWn9hRpHkR5o/IEFdQWtgVVl3cVVABoeTKYwnoVA4ywu+wz1 baJHLKSe79K4oqGuHaBdiUpajInxc3m7S/kn9p3YdRehBZ3Wv3ltwlRk3mlqhBEfdtA+/WxpD Hk1GwGCTyldiAbB0MESiOITimuH+9F6VbaFFcgX8rWkNGLWq61s7oM3WmKEeNgaPJ33QLR2Q5 +X2sS2M1Fksea2Hsl9Wqf3fqp+X1T2kct3OzhYqfvy97GLbrKOxWuA3gFt2/GESJqFC+hwgZI hDqPnTlKx5UtVMeHferz1VkvRoMNFakAY8ePkR42i8LqZ772E9751WdxjZKfgpi5XlZkxk6zS AYQGNBktTROAGQuzc7FnrafM/FOi+QU9VZflfMoLcnt2ER25WKbFBE+/f+nT2k0v5LoePKX1N XtFAI+eHZVxr0ctQpujCZWII9g0H3VZtLsmmjGFEAgjuM54gVaJZ8eyJL4iYQhfOoI63ZFWly Tg+oX1jggIcm/s+qdtNVUPWANsI6IHlSDyDPufkuJFPCEjWb2HUsDdYViAWTtr Subject: Re: [FFmpeg-devel] forgejo merge vs approve X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Strasser via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Alexander Strasser Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2025-08-03 17:04 +0200, Timo Rothenpieler wrote: > On 8/3/2025 3:26 PM, Michael Niedermayer wrote: > > On Sun, Aug 03, 2025 at 01:45:17PM +0200, Timo Rothenpieler wrote: > > > On 8/3/2025 9:41 AM, Michael Niedermayer wrote: > > > > Hi > > > > > > > > can we have a tag that causes "automerge on approve" ? > > > > > > > > so that if i open a pr i can set that tag and if someone approves it, its > > > > merged and i dont have to come back and click that button ? > > > > > > That is how it should already work normally. > > > If there is no approval, the merge button turns into a "Auto-Merge when > > > checks succeed", and "at least one approval" is said check. > > > > > > Not sure if being an admin lets you bypass that, but at least I also see the > > > "Rebase then fw (When checks succeed)" button. > > > > ok lets see if that works > > I saw one button and i clicked it on > > "https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20093" > > > > lets see if it waits for an approval :) > > > > btw how exactly does that work when a pull request crosses the area > > of knowledge of 5 people ? > > You probably shouldn't mark such PRs for auto-merge on approval. > I'd only use it on more or less obvious/trivial things. Fully agree with Timo. One should act responsibly and only use auto-merge on very small, mostly trivial changes. For bigger stuff I think it's best to let either the main author or the main reviewer do the merge. Where the author is only possible when they have write access and with main reviewer I mean a reviewer that fully reviewed the changes and not only partially. This is usually the best option because they have a better mental model of how things work and what gets changed and don't want to introduce errors themselves when actively merging the changes. So things that might have been not found yet still have a good chance to pop up last minute. Alexander _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".