[FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

[FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

[Romain Beauxis]

Hi all,

Are there any recommendations on how to best get attention to some
patches/changes?

With the introduction of the new forgejo workflow (which I personally
welcome!), I am wondering how casual contributors like myself should
approach the task of finding reviewers.

So far, I am aware of the following:
* Contact a listed MAINTAINER if they are still active
* Get attention on the Mailing List.
* Ping people on IRC
* Forgejo?

The advantage of the ML for this problem is that all patches are visible to
all subscribers. But, for Forgejo, it seems very easy to have PRs fall
through the cracks.

The only thing that I can think of at the moment is to assign to people
that have been active in reviewing other PRs.

Is there a better suggested way? Should the ML be used to advertise PRs up
for review?

For a practical reference, here's my situation: while working on fixing ogg
muxer/demuxer, I have had success getting some response from a general
standpoint but I have never found someone committed to working on the ogg
subset of the project and the listed MAINTAINER does not seem active
anymore.

I understand that ogg is an old container but it is still the standard
container for a lot of online streaming and ffmpeg is the default
implementation for most browsers reading (and more). It seems like it
should be in the interest of the project to improve its support?

The patch in question is here:
https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026
Or here on the ML:
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344442.html

The larger context is a rewrite of the ogg/demuxer when working with
sequential streams to:
* Remove stream packet headers from the demuxer (as suggested by Lynne)
* Fix PTS/DTS discontinuity. Subsequent ogg logical stream currently reset
the PTS/DTS counter which is a problem.
* Support copy-only repackaging of sequentialized ogg streams.

Any advice would be welcome. Thanks!
-- Romain
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Recommendations to facilitation patch reviews on forgejo/ML?

[Nicolas George]

Romain Beauxis (HE12025-07-29):
> Are there any recommendations on how to best get attention to some
> patches/changes?

Speaking for myself, I will not lift a finger to adapt to this thing
until the dust is settles and the promises that were made about a full
ability to interact by mail and command-lie are met, including specific
documentation.

And if a patch is pushed that affects the areas I am responsible of
without me seeing it, I reserve the right to revert on the spot.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".