From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Alexander Strasser <eclipse7@gmx.net>
Subject: Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"
Date: Sat, 2 Aug 2025 20:08:32 +0200
Message-ID: <aI5UIGll1J_epu7K@phare.normalesup.org> (raw)
In-Reply-To: <aI452mPd2h2xFmF0@metallschleim.local>
Alexander Strasser via ffmpeg-devel (HE12025-08-02):
> I don't understand what the issue with the commit message is?
Two issues:
- Form: “>” is not part of our practice for commit message. Look at the
past year of commit message, the only ones that include “>” lines are
mistakes.
- Substance: “To my understanding”, either the patch was reviewed, and
nobody's individual understanding has to be mentioned in the commit
message, or it was not and it should not have been applied.
It is minor, but there is a reason we historically gave write access
only to experienced contributors: two pairs of eyes are better than one
to fix this kind of minor mistakes and keep our history as clean as
possible.
Regards,
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-08-02 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250730174635.C39D4412998@natalya.videolan.org>
2025-07-30 17:52 ` Nicolas George
2025-07-30 18:34 ` Kacper Michajlow
2025-07-30 18:53 ` Niklas Haas
2025-07-30 19:53 ` Nicolas George
2025-07-30 21:03 ` Kacper Michajlow
2025-07-30 21:39 ` Nicolas George
2025-07-30 21:59 ` Niklas Haas
2025-07-30 22:02 ` Nicolas George
2025-08-02 16:16 ` Alexander Strasser via ffmpeg-devel
2025-08-02 18:08 ` Nicolas George [this message]
2025-08-02 19:03 ` Alexander Strasser via ffmpeg-devel
2025-07-30 23:00 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aI5UIGll1J_epu7K@phare.normalesup.org \
--to=george@nsup.org \
--cc=eclipse7@gmx.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git