From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9DA604C3A1 for ; Sat, 2 Aug 2025 12:17:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0FEC468CD28; Sat, 2 Aug 2025 15:17:28 +0300 (EEST) Received: from nef.ens.fr (nef2.ens.fr [129.199.96.40]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2B95668B8C6; Sat, 2 Aug 2025 15:17:16 +0300 (EEST) X-ENS-nef-client: 129.199.129.80 ( name = phare.normalesup.org ) Received: from phare.normalesup.org (phare.normalesup.org [129.199.129.80]) by nef.ens.fr (8.14.4/1.01.28121999) with ESMTP id 572CHFAD000884 ; Sat, 2 Aug 2025 14:17:15 +0200 Received: by phare.normalesup.org (Postfix, from userid 1001) id 2759E2EFE3; Sat, 2 Aug 2025 14:17:15 +0200 (CEST) Date: Sat, 2 Aug 2025 14:17:15 +0200 From: Nicolas George To: FFmpeg development discussions and patches Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (nef.ens.fr [129.199.96.32]); Sat, 02 Aug 2025 14:17:15 +0200 (CEST) Subject: Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Kieran Kunhya , tc@ffmpeg.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Kieran Kunhya via ffmpeg-devel (HE12025-07-29): > Hello, > > It seem there is strong evidence that AI wrote TLS code as part of the > WHIP patch. It goes without saying why this is bad. Further discussion > here: > https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20053 > > This patch was pushed without ML review. > > I think this code should be removed before the FFmpeg release. I > include TC in this email for that reason. For what it is worth, I agree with you. The bugs introduced by AI are different from bugs introduced by humans, and we do not have the training to spot them efficiently. Furthermore, I just looked at 167e343bbe, and it should never gotten in, for reasons that jump to the eye, starting with the fact that it contains multiple independent changes, and continuing with the fact the coding style of the new code does not match ours and the fact that the commit message contains references to previous versions of the same patch. Let us revert that at once. Regards, -- Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".