Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nicolas George <george@nsup.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Kieran Kunhya <kieran618@googlemail.com>, tc@ffmpeg.org
Subject: Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch
Date: Sat, 2 Aug 2025 14:17:15 +0200
Message-ID: <aI4By6zBUG9YLS8R@phare.normalesup.org> (raw)
In-Reply-To: <CABGuwEmoDQix1u4B2KJmd3BjhZLoSzmxNTqEg8=GmHt2WjFcQA@mail.gmail.com>

Kieran Kunhya via ffmpeg-devel (HE12025-07-29):
> Hello,
> 
> It seem there is strong evidence that AI wrote TLS code as part of the
> WHIP patch. It goes without saying why this is bad. Further discussion
> here:
> https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20053
> 
> This patch was pushed without ML review.
> 
> I think this code should be removed before the FFmpeg release. I
> include TC in this email for that reason.

For what it is worth, I agree with you. The bugs introduced by AI are
different from bugs introduced by humans, and we do not have the
training to spot them efficiently.

Furthermore, I just looked at 167e343bbe, and it should never gotten in,
for reasons that jump to the eye, starting with the fact that it
contains multiple independent changes, and continuing with the fact the
coding style of the new code does not match ours and the fact that the
commit message contains references to previous versions of the same
patch.

Let us revert that at once.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2025-08-02 12:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 20:02 Kieran Kunhya via ffmpeg-devel
2025-07-29 20:11 ` James Almer
2025-07-29 20:56   ` Kacper Michajlow
2025-07-29 22:39     ` James Almer
2025-07-29 22:59       ` Timo Rothenpieler
2025-07-30  0:42 ` Jack Lau
2025-07-31 11:26 ` Niklas Haas
2025-08-02 12:17 ` Nicolas George [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aI4By6zBUG9YLS8R@phare.normalesup.org \
    --to=george@nsup.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=kieran618@googlemail.com \
    --cc=tc@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git