Re: [FFmpeg-devel] [PATCH v8 14/18] swscale/ops_memcpy: add 'memcpy' backend for plane->plane copies - Alexander Strasser via ffmpeg-devel

From: Alexander Strasser via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Alexander Strasser <eclipse7@gmx.net>
Subject: Re: [FFmpeg-devel] [PATCH v8 14/18] swscale/ops_memcpy: add 'memcpy' backend for plane->plane copies
Date: Mon, 14 Jul 2025 22:41:42 +0200
Message-ID: <aHVrhnOk651MeSA0@metallschleim.local> (raw)
In-Reply-To: <20250714105115.GD56899@haasn.xyz>

Hi Niklas!

On 2025-07-14 10:51 +0200, Niklas Haas wrote:
> On Sun, 13 Jul 2025 19:04:21 +0200 Alexander Strasser via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> > On 2025-07-12 12:44 +0200, Niklas Haas wrote:
[...]
> > > +
> > > +SwsOpBackend backend_murder = {
> > > +    .name    = "memcpy",
> > > +    .compile = compile,
> > > +};
> >
> > Is this intentional?
> > While everything is name `memcpy` the variables are namend `_murder`?
> 
> It's an (IMO) harmless joke. I can remove it if you'd prefer.

I would prefer it, but if you want to keep it that's also fine with me!
If you do change it, don't re-send the series only because of that change.

Just wanted to make sure it's intentional. Personally I'm fine with such
things, it just is a bit weird when you don't get the joke.

I don't dare to ask about the joke, because of the usual disclaimers for
explaining jokes *lol

Jokes aside; one rather minor thing it definitely makes a bit worse is
text searching for `backend_memcpy` where you won't find where it is
registered because you failed to search for `backend_murder` instead.

Best regards,
  Alexander
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".