Re: [FFmpeg-devel] [PATCH 1/1] avfilter/abufsrc: add audio buffer source filter with dynamic routing.

[Nicolas George <george@nsup.org>]

cenzhanquan2@gmail.com (HE12025-07-21):
> From: zhanquan cen <cenzhanquan2@gmail.com>

Hi. Thanks for the patch, but it seems to be suffering from some design
flaws.

> This commit introduces a new audio buffer source filter `abufsrc`
> designed for scenarios requiring dynamic audio routing and real-time
> processing control. Key features include:
> 1. **Multi-Output Routing**: Supports configurable mapping of input to
> multiple outputs via `map` option, enabling selective audio stream
> distribution[4,6](@ref).

What does that mean? There is no documentation. This “[4,6](@ref)” might
be a pointer towards documentation, but where is it?

> 2. **Fade Effects**: Implements sample-accurate fade-in/fade-out
> transitions during playback start/stop, handling edge cases like
> pause/resume and buffer underruns[8](@ref).

We already have this in other filters. Duplicating the feature in the
input buffer filter is a big no. Duplicating the code is an even bigger
no.

> 3. **Volume Control**: Integrates with volume scaling system, allowing
> runtime adjustment through `player_volume` and `volume` parameters.

Same as above, we already have a volume filter.

> 4. **Event Callbacks**: Uses `on_event_cb` for asynchronous frame
> request mechanism, decoupling filter activation from external data
> sources.

Again, documentation missing to even guess if that is relevant or not.

> 5. **Command API**: Exposes control via `link/unlink/map/pause/resume`
> commands for dynamic pipeline reconfiguration.

If an application wants to pause the input of its filter graph, it just
needs to stop feeding it frames.

Regards,

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".