From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 44FCD4E273 for ; Tue, 8 Jul 2025 08:50:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id CA90368F099; Tue, 8 Jul 2025 11:50:49 +0300 (EEST) Received: from mx.sdf.org (mx.sdf.org [205.166.94.24]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CCA8568EB37 for ; Tue, 8 Jul 2025 11:50:43 +0300 (EEST) Received: from 436df3412bf9621d289a69bf8f875853 ([1.136.104.214]) (authenticated (0 bits)) by mx.sdf.org (8.18.1/8.14.3) with ESMTPSA id 5688oYX3026055 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for ; Tue, 8 Jul 2025 08:50:40 GMT Date: Tue, 8 Jul 2025 18:50:34 +1000 From: Peter Ross To: FFmpeg development discussions and patches Message-ID: Mail-Followup-To: FFmpeg development discussions and patches References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0403757099175023961==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0403757099175023961== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LtyC7lGlVOJ+ns+K" Content-Disposition: inline --LtyC7lGlVOJ+ns+K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 07, 2025 at 12:41:34PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes CID1655273 and CID1655274. > > --- > > libavcodec/adpcm.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > >=20 > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > > index 92ab248f3d..527384b86d 100644 > > --- a/libavcodec/adpcm.c > > +++ b/libavcodec/adpcm.c > > @@ -877,6 +877,9 @@ static int adpcm_sanyo_expand3(ADPCMChannelStatus *= c, int bits) > > add =3D (11 * c->step) >> 1; > > c->step =3D 3 * c->step; > > break; > > + default: > > + av_assert0(0); /* never reach here when bits is 3-bit */ > > + return 0; > > } > > =20 > > if (sign) > > @@ -934,6 +937,9 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *= c, int bits) > > add =3D (25 * c->step) >> 1; > > c->step =3D 5 * c->step; > > break; > > + default: > > + av_assert0(0); /* never reach here when bits is 4-bit */ > > + return 0; > > } > > =20 > > if (sign) > >=20 >=20 > Why not av_unreachable()? this macro was added last month, thanks for bringing it to my attention :) -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) --LtyC7lGlVOJ+ns+K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSpB+AvpuUM0jTNINJnYHnFrEDdawUCaGzb2gAKCRBnYHnFrEDd a+PqAKCdakZeTZWGlDpKaOm3ucmPGsXTygCfb4ZvYshRlyZHK8ppvZo2Bw1E/yk= =21Qn -----END PGP SIGNATURE----- --LtyC7lGlVOJ+ns+K-- --===============0403757099175023961== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0403757099175023961==--